Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow decimals starting with 0 #27

Open
IstoraMandiri opened this issue Jan 21, 2019 · 1 comment
Open

Allow decimals starting with 0 #27

IstoraMandiri opened this issue Jan 21, 2019 · 1 comment
Assignees
@IstoraMandiri @BTCln

Comments

@IstoraMandiri
Copy link
Contributor

The logic for the keypad will ignore number starting with 0, meaning it will only accept decimals above 1. This isn't good for currencies like dollars.

invoicer-ui/src/components/KeyPad.jsx

Line 31 in 0064c2d

|| (value.indexOf('0') === 0 && text === '')

Maybe we should make decimals a configurable option in the component (not needed for THB).
@nolim1t
Copy link
Member

nolim1t commented Jan 21, 2019

THB has decimals btw... just that its rarely used it these days (hello inflation)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IstoraMandiri IstoraMandiri

@BTCln BTCln

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nolim1t @IstoraMandiri @BTCln