{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":856017133,"defaultBranch":"main","name":"aws-cdk","ownerLogin":"libertymutual","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2024-09-11T20:57:55.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/4512700?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1726249086.0","currentOid":""},"activityList":{"items":[{"before":"dc79508be527bbb9ed8beb532fe78a2e9bc0a68e","after":"8e88f82f07867b5c8c9329dfec90eae41b10cf9d","ref":"refs/heads/nodegroup-gpu-instance-types","pushedAt":"2024-09-16T13:01:26.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"AlexKaracaoglu","name":"Alex Karacaoglu","path":"/AlexKaracaoglu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/31391932?s=80&v=4"},"commit":{"message":"chore(eks): update nodegroup gpu check and add gpu instance type","shortMessageHtmlLink":"chore(eks): update nodegroup gpu check and add gpu instance type"}},{"before":"b541b427cc49a9952f4596cbcdf976c1e17fe5d6","after":"dc79508be527bbb9ed8beb532fe78a2e9bc0a68e","ref":"refs/heads/nodegroup-gpu-instance-types","pushedAt":"2024-09-13T20:27:02.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"AlexKaracaoglu","name":"Alex Karacaoglu","path":"/AlexKaracaoglu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/31391932?s=80&v=4"},"commit":{"message":"chore(eks): update nodegroup gpu check and add gpu instance type","shortMessageHtmlLink":"chore(eks): update nodegroup gpu check and add gpu instance type"}},{"before":"5123e88eb1cf48b1f8908c83f2893cd4a39489bf","after":"b541b427cc49a9952f4596cbcdf976c1e17fe5d6","ref":"refs/heads/nodegroup-gpu-instance-types","pushedAt":"2024-09-13T19:48:03.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"AlexKaracaoglu","name":"Alex Karacaoglu","path":"/AlexKaracaoglu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/31391932?s=80&v=4"},"commit":{"message":"Merge branch 'main' into nodegroup-gpu-instance-types","shortMessageHtmlLink":"Merge branch 'main' into nodegroup-gpu-instance-types"}},{"before":"ec9e235f0fd0754957844de434412a30e1e760f5","after":null,"ref":"refs/heads/managed-nodegroup-gpu-instance-type-refresh","pushedAt":"2024-09-13T17:38:06.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"AlexKaracaoglu","name":"Alex Karacaoglu","path":"/AlexKaracaoglu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/31391932?s=80&v=4"}},{"before":"bf3764fe6046799a2a6e074b39b9a5f4474c603c","after":"5123e88eb1cf48b1f8908c83f2893cd4a39489bf","ref":"refs/heads/nodegroup-gpu-instance-types","pushedAt":"2024-09-13T17:37:41.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"AlexKaracaoglu","name":"Alex Karacaoglu","path":"/AlexKaracaoglu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/31391932?s=80&v=4"},"commit":{"message":"chore(eks): update nodegroup gpu check and add gpu instance type","shortMessageHtmlLink":"chore(eks): update nodegroup gpu check and add gpu instance type"}},{"before":null,"after":"bf3764fe6046799a2a6e074b39b9a5f4474c603c","ref":"refs/heads/nodegroup-gpu-instance-types","pushedAt":"2024-09-13T17:35:24.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"AlexKaracaoglu","name":"Alex Karacaoglu","path":"/AlexKaracaoglu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/31391932?s=80&v=4"},"commit":{"message":"chore(elasticloadbalancingv2): add validation for `RedirectOptions.path` (#31202)\n\n### Issue # (if applicable)\n\nCloses #31201 .\n\n### Reason for this change\n\n\nIf we set a string without a leading `/` for the path property, deployment will fail as shown below.\n\nGiven:\n\n```ts\nhttpListener.addAction('RedirectAction', {\n        conditions: [elbv2.ListenerCondition.pathPatterns(['/*'])],\n        action: elbv2.ListenerAction.redirect({\n          protocol: elbv2.ApplicationProtocol.HTTPS,\n          path: 'example/path? ',\n          permanent: true\n        }),\n      })\n```\n\nResult:\n\n```sh\nFailed resources:\nMainStack-develop | 1:34:02 AM | CREATE_FAILED | AWS::ElasticLoadBalancingV2::ListenerRule | Alb/HttpListener/RedirectActionRule (AlbHttpListenerRedirectActionRule1D930694) Internal error reported from downstream service during operation 'The Path parameter must be a valid path, should start with a '/', and may contain up to one of each of these placeholders: '#{path}', '#{host}', '#{port}'. (Service: ElasticLoadBalancingV2, Status Code: 400, Request ID: fd4c7f01-9c97-44c1-a177-30ac04b2db26)'.\n```\n\nRelated docs: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-elasticloadbalancingv2-listenerrule-redirectconfig.html#cfn-elasticloadbalancingv2-listenerrule-redirectconfig-path\n\n### Description of changes\n\nAdd validation for `path` prop like below.\n\n```ts\n    if (options.path && !options.path.startsWith('/')) {\n      throw new Error('Redirect path must start with a \\'/\\'');\n    }\n```\n\n### Description of how you validated changes\n\nAdd unit test.\n\n### Checklist\n- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)\n\n----\n\n*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*","shortMessageHtmlLink":"chore(elasticloadbalancingv2): add validation for `RedirectOptions.pa…"}},{"before":"bf3764fe6046799a2a6e074b39b9a5f4474c603c","after":"ec9e235f0fd0754957844de434412a30e1e760f5","ref":"refs/heads/managed-nodegroup-gpu-instance-type-refresh","pushedAt":"2024-09-13T17:28:31.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"AlexKaracaoglu","name":"Alex Karacaoglu","path":"/AlexKaracaoglu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/31391932?s=80&v=4"},"commit":{"message":"chore(eks): update nodegroup gpu check and add gpu instance type","shortMessageHtmlLink":"chore(eks): update nodegroup gpu check and add gpu instance type"}},{"before":"aedf617a754fff87d3cde7efbb996bec6f0fa129","after":"bf3764fe6046799a2a6e074b39b9a5f4474c603c","ref":"refs/heads/managed-nodegroup-gpu-instance-type-refresh","pushedAt":"2024-09-13T13:38:37.000Z","pushType":"push","commitsCount":8,"pusher":{"login":"AlexKaracaoglu","name":"Alex Karacaoglu","path":"/AlexKaracaoglu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/31391932?s=80&v=4"},"commit":{"message":"chore(elasticloadbalancingv2): add validation for `RedirectOptions.path` (#31202)\n\n### Issue # (if applicable)\n\nCloses #31201 .\n\n### Reason for this change\n\n\nIf we set a string without a leading `/` for the path property, deployment will fail as shown below.\n\nGiven:\n\n```ts\nhttpListener.addAction('RedirectAction', {\n        conditions: [elbv2.ListenerCondition.pathPatterns(['/*'])],\n        action: elbv2.ListenerAction.redirect({\n          protocol: elbv2.ApplicationProtocol.HTTPS,\n          path: 'example/path? ',\n          permanent: true\n        }),\n      })\n```\n\nResult:\n\n```sh\nFailed resources:\nMainStack-develop | 1:34:02 AM | CREATE_FAILED | AWS::ElasticLoadBalancingV2::ListenerRule | Alb/HttpListener/RedirectActionRule (AlbHttpListenerRedirectActionRule1D930694) Internal error reported from downstream service during operation 'The Path parameter must be a valid path, should start with a '/', and may contain up to one of each of these placeholders: '#{path}', '#{host}', '#{port}'. (Service: ElasticLoadBalancingV2, Status Code: 400, Request ID: fd4c7f01-9c97-44c1-a177-30ac04b2db26)'.\n```\n\nRelated docs: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-elasticloadbalancingv2-listenerrule-redirectconfig.html#cfn-elasticloadbalancingv2-listenerrule-redirectconfig-path\n\n### Description of changes\n\nAdd validation for `path` prop like below.\n\n```ts\n    if (options.path && !options.path.startsWith('/')) {\n      throw new Error('Redirect path must start with a \\'/\\'');\n    }\n```\n\n### Description of how you validated changes\n\nAdd unit test.\n\n### Checklist\n- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)\n\n----\n\n*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*","shortMessageHtmlLink":"chore(elasticloadbalancingv2): add validation for `RedirectOptions.pa…"}},{"before":null,"after":"aedf617a754fff87d3cde7efbb996bec6f0fa129","ref":"refs/heads/managed-nodegroup-gpu-instance-type-refresh","pushedAt":"2024-09-13T13:15:33.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"AlexKaracaoglu","name":"Alex Karacaoglu","path":"/AlexKaracaoglu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/31391932?s=80&v=4"},"commit":{"message":"chore(rds): deprecate CA certificate rds-ca-2019 (#31387)\n\n### Reason for this change\n\n\n\nThe certificate `rds-ca-2019` expired in August, 2024.\n\n> Amazon RDS Certificate Authority certificates rds-ca-2019 are set to expire in August, 2024.\n\nhttps://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/UsingWithRDS.SSL-certificate-rotation.html\n\nI also confirmed in CLI:\n\n```\n❯ aws rds describe-db-engine-versions --default-only --engine postgres\n{\n    \"DBEngineVersions\": [\n        {\n            ...\n            ...\n            \"SupportedCACertificateIdentifiers\": [\n                \"rds-ca-ecc384-g1\",\n                \"rds-ca-rsa4096-g1\",\n                \"rds-ca-rsa2048-g1\"\n            ],\n        }\n    ]\n}\n```\n\nCFn deploy errors:\n\n```\nResource handler returned message: \"Certificate not found: rds-ca-2019 (Service: Rds, Status Code: 404, Request ID: ...\"\n```\n\n### Description of changes\n\n\n\nDeprecate the certificate.\n\n### Description of how you validated changes\n\n\n\n### Checklist\n- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)\n\n----\n\n*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*","shortMessageHtmlLink":"chore(rds): deprecate CA certificate rds-ca-2019 (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2516681141\" data-permission-text=\"Title is private\" data-url=\"https://github.com/aws/aws-cdk/issues/31387\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/aws/aws-cdk/pull/31387/hovercard\" href=\"https://github.com/aws/aws-cdk/pull/31387\">aws#31387</a>)"}},{"before":"473cf1d7be473fb72d80cf70072b6b2caa9fcec0","after":"bf3764fe6046799a2a6e074b39b9a5f4474c603c","ref":"refs/heads/main","pushedAt":"2024-09-13T13:13:09.000Z","pushType":"push","commitsCount":16,"pusher":{"login":"jdesulme","name":"Jean Desulme","path":"/jdesulme","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1392291?s=80&v=4"},"commit":{"message":"chore(elasticloadbalancingv2): add validation for `RedirectOptions.path` (#31202)\n\n### Issue # (if applicable)\n\nCloses #31201 .\n\n### Reason for this change\n\n\nIf we set a string without a leading `/` for the path property, deployment will fail as shown below.\n\nGiven:\n\n```ts\nhttpListener.addAction('RedirectAction', {\n        conditions: [elbv2.ListenerCondition.pathPatterns(['/*'])],\n        action: elbv2.ListenerAction.redirect({\n          protocol: elbv2.ApplicationProtocol.HTTPS,\n          path: 'example/path? ',\n          permanent: true\n        }),\n      })\n```\n\nResult:\n\n```sh\nFailed resources:\nMainStack-develop | 1:34:02 AM | CREATE_FAILED | AWS::ElasticLoadBalancingV2::ListenerRule | Alb/HttpListener/RedirectActionRule (AlbHttpListenerRedirectActionRule1D930694) Internal error reported from downstream service during operation 'The Path parameter must be a valid path, should start with a '/', and may contain up to one of each of these placeholders: '#{path}', '#{host}', '#{port}'. (Service: ElasticLoadBalancingV2, Status Code: 400, Request ID: fd4c7f01-9c97-44c1-a177-30ac04b2db26)'.\n```\n\nRelated docs: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-elasticloadbalancingv2-listenerrule-redirectconfig.html#cfn-elasticloadbalancingv2-listenerrule-redirectconfig-path\n\n### Description of changes\n\nAdd validation for `path` prop like below.\n\n```ts\n    if (options.path && !options.path.startsWith('/')) {\n      throw new Error('Redirect path must start with a \\'/\\'');\n    }\n```\n\n### Description of how you validated changes\n\nAdd unit test.\n\n### Checklist\n- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)\n\n----\n\n*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*","shortMessageHtmlLink":"chore(elasticloadbalancingv2): add validation for `RedirectOptions.pa…"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0xNlQxMzowMToyNi4wMDAwMDBazwAAAAS3brar","startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0xNlQxMzowMToyNi4wMDAwMDBazwAAAAS3brar","endCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0xM1QxMzoxMzowOS4wMDAwMDBazwAAAAS1gUjM"}},"title":"Activity · libertymutual/aws-cdk"}