Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking Fuel in trips doesn't go to fuel #300

Open
windley opened this issue Nov 26, 2014 · 2 comments
Open

Clicking Fuel in trips doesn't go to fuel #300

windley opened this issue Nov 26, 2014 · 2 comments
Milestone

Comments

@windley
Copy link
Member

windley commented Nov 26, 2014

When you're looking at a trip detail for a vehicle and click the fuel icon, you stay where you're at rather than going to fuel page for that vehicle.

I've confirmed that the call to the backend happens, so the app thinks it's doing something.

@windley windley added the Bug label Nov 26, 2014
@windley
Copy link
Member Author

windley commented Nov 26, 2014

This happens because when we come from the detail page, the "id" that is passed to showFuel (in controller) is the trip ID rather than the pico ID for the vehicle. So, there's no vehicle context.

@windley
Copy link
Member Author

windley commented Nov 26, 2014

Hey @alexkolson can you take a look at this. I spent 45 minutes trying to understand the flow, where IDs are, etc. and while I've got some clues, I'm lost.

I do know that the ID that shows up in the page route for a trip detail page is the trip ID whereas it's the vehicle ID (pico ID) when I'm looking at trip summary page. But I can't see how clicking on the Fuel icon actually translates into action with parameters.

@alexkolson alexkolson added this to the 1.1.0 milestone May 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants