-
Notifications
You must be signed in to change notification settings - Fork 1.5k
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce finalizerProbe for the pods like we have livenessProbe #4757
Comments
/sig app |
@bitsmaestro: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/sig app |
@bitsmaestro: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/sig apps |
Like HTTP we can implement similar concept for TCP probes and GRPC Health Checking Protocol also |
Enhancement Description
Requirement: while deleting a pod API server is not sure if anything on that pod is running or not. May be pod is still processing response for some rest call and we may loose it.
Enhancement: So suggestion is introduce an finalizerProbe which when curled should return if Pod is ready to die or not.
this should only be used when we get some external delete with force option, all other deletion scenarios should not care about finalizerProbe
finalizerProbe should return 500 if not ready to be deleted & 200 when ready to be deleted
Application inside the pod should ensure the logic to return return 500 or 200 as per the business
that new request is not accepted once a finalizerProbe is called or metadata.deletionTimestamp is added to the pod.
k/enhancements
) update PR(s):k/k
) update PR(s):k/website
) update PR(s):Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.
The text was updated successfully, but these errors were encountered: