Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infinite reload when session secret is reset #8028

Closed
flexdinesh opened this issue Oct 21, 2022 · 0 comments · Fixed by #8038
Closed

Infinite reload when session secret is reset #8028

flexdinesh opened this issue Oct 21, 2022 · 0 comments · Fixed by #8038
Labels
🐛 bug Unresolved bug

Comments

@flexdinesh
Copy link
Contributor

flexdinesh commented Oct 21, 2022 •
edited
Loading

When session secret is reset between hot reloads during development, Admin UI goes into an infinite reload loop.

It's easy to reproduce with the latest [email protected] where we generate a new session secret with every reload.

Steps to reproduce

  1. npx create-keystone-app@latest session-bug
  2. Create your first user and login to the Admin UI
  3. Add a random console.log() anywhere in the code
  4. Refresh Admin UI and it will infinitely reload
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug Unresolved bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix changes to some config not being updated in live reloads keystonejs/keystone
1 participant
@flexdinesh