Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when using HBAO #41

Open
phields opened this issue May 20, 2019 · 4 comments
Open

Error when using HBAO #41

phields opened this issue May 20, 2019 · 4 comments
Assignees
Labels

Comments

@phields
Copy link

phields commented May 20, 2019

123
caused by [AddComponentMenu(null)]

@keijiro keijiro self-assigned this May 21, 2019
@keijiro
Copy link
Owner

keijiro commented May 21, 2019

Sorry, I think your question is not related to this repository. Actually, I have no idea about what HBAO is.

@keijiro
Copy link
Owner

keijiro commented May 21, 2019

I'm closing this issue. Please feel free to reopen for further questions.

@keijiro keijiro closed this as completed May 21, 2019
@phields
Copy link
Author

phields commented May 22, 2019

@keijiro Sorry, maybe my explanation is wrong.
I found that Klak's Patch could not be started after importing HBAO plugin from the AssetsStore.
The problem is caused by this code

[AddComponentMenu(null)]

so actually it has nothing to do with HBAO.

@keijiro keijiro reopened this May 22, 2019
@keijiro
Copy link
Owner

keijiro commented May 22, 2019

Thanks for the explanation. I think giving null to AddComponentMenu is not a nice way to hide the component from the menu, but it seems some people prefer using this trick. Hmm. Okay.

I'd like to fix it in a future update. At the moment, it's recommended removing that line to avoid the error. Or I think it can be fixed by changing null to "" (empty string).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants