Can't set "languages" for fields of type langdetect when profile is shorttext

[ptanov]

There is a check (

elasticsearch-plugin-bundle/src/main/java/org/xbib/elasticsearch/plugin/bundle/common/langdetect/LangdetectService.java

Line 172 in e75891a

List<String> keys = "shorttext".equals(profile) ?

) and when the profile is shorttext then languages_short_text is used but it is never set in builder/parser:

elasticsearch-plugin-bundle/src/main/java/org/xbib/elasticsearch/plugin/bundle/index/mapper/langdetect/LangdetectMapper.java

Line 391 in e75891a

case "languages":

(only languages are set)

[ptanov]

In this fix we first try to get the value of languages list (if available) before using the default value for languages_short_text. We don't need initialization of languages in DEFAULT_SETTINGS because we provide a default value when getting the languages (

elasticsearch-plugin-bundle/src/main/java/org/xbib/elasticsearch/plugin/bundle/common/langdetect/LangdetectService.java

Line 174 in e75891a

settings.getAsList("languages", Arrays.asList(DEFAULT_LANGUAGES));

). By doing that we ensure that DEFAULT_LANGUAGES_SHORT_TEXT will be used if no configuration is provided (default constructor). The only drawback of this approach is if someone provide settings that contains languages but not contains languages_short_text and actually want to use DEFAULT_LANGUAGES_SHORT_TEXT. This case could be avoided if the default constructor is used in the situation.

However test case needs to be created...

[jprante]

Nice catch, thanks