Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preset concept should be moved to the "module" bounded context #10651

Open
murdos opened this issue Aug 23, 2024 · 2 comments
Open

Preset concept should be moved to the "module" bounded context #10651

murdos opened this issue Aug 23, 2024 · 2 comments

Comments

@murdos
Copy link
Contributor

murdos commented Aug 23, 2024

A preset is collection of preselected modules that could be applied together, so it rather belong to the "module" bounded context.

It actually resides in the "project" bounded context, whereas this bounded context deals with an existing generated project: history of applied modules, download of the project, ...

@renanfranca
Copy link
Contributor

I agree. I thought about that while I was doing it. I decided on my last commit to where it should go 😅

So it's going to be at the same place as the list of modules, isn't it?

@murdos
Copy link
Contributor Author

murdos commented Aug 24, 2024

I agree. I thought about that while I was doing it. I decided on my last commit to where it should go 😅

😅 I also did not pay attention to that when I've reviewed the code. I saw that accidentally while looking for the best location for the automatic cleanup of generated projects (#10575)

So it's going to be at the same place as the list of modules, isn't it?

I think it makes more sense. Alongside landscape stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants