Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS-level erros during printing are ignored #1837

Open
2 tasks done
FarSeeing opened this issue Aug 16, 2024 · 0 comments
Open
2 tasks done

OS-level erros during printing are ignored #1837

FarSeeing opened this issue Aug 16, 2024 · 0 comments

Comments

@FarSeeing
Copy link

Preflight Checklist

  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for a feature request that matches the one I want to file, without success.

You must agree to search and the code of conduct. You must fill in this entire template. If you delete part/all or miss parts out your issue will be closed.

Describe the bug
If any error (like no printer found) happens during at attempt to print a file it just gets silenced:

contents.print(pdfOptions, (success, errorType) => 
{
	//Consider all as success
	event.reply('export-success', {});
});

Probably it's redundant to handle each error but just displaying a message like "something went wrong" would be enough.

Expected behavior
An error message gets shown if anything happens.

draw.io version (In the Help->About menu of the draw.io editor):

  • draw.io version 24.7.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant