Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link to code in markdown #10

Open
bkeepers opened this issue Jan 8, 2018 · 1 comment
Open

Link to code in markdown #10

bkeepers opened this issue Jan 8, 2018 · 1 comment

Comments

@bkeepers
Copy link
Contributor

bkeepers commented Jan 8, 2018

If you paste a link to code on GitHub in a comment, the code snippet gets rendered as a table. This should probably just be translated into a link to the file and a code snippet in mrkdwn.

slack_-_github
@stephenyeargin
Copy link

stephenyeargin commented Apr 18, 2018 •
edited
Loading

(@izuzak sent me over as this may be the component that needs ❤️ to address things. Let me know if this belongs in another repository.)

Scenario:

  1. Go to a particular PR and get a permalink to a particular block of code
  2. Add that permalink as part of a comment on a PR
  3. The GitHub integration takes that comment and posts it to Slack
  4. Observe code block formatting lost in translation

GitHub Comment

github view

Slack Post

slack view

Linking these as they appear to be related:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bkeepers @stephenyeargin