Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tonic-health required services #1930

Open
splix opened this issue Sep 6, 2024 · 0 comments
Open

tonic-health required services #1930

splix opened this issue Sep 6, 2024 · 0 comments

Comments

@splix
Copy link

splix commented Sep 6, 2024

Feature Request

Crates

tonic-health

Motivation

Right now it reports the health status per named service + a "default" service, which starts as Serving but can be updated later.

Kubernetes, for example, can subscribe only to one of them, and usually the "default" one is sufficient.
I.e., the default service is the thing that actually matters. That leads to different decisions how exactly to maintain it, especially in the case when you have multiple required services. I.e, when a failure of any of them means that the whole app is unhealthy. Ex. "App should be considered healthy when both Postgres and Kafka are connected".

Proposal

Add an optional list of required services (i.e., a Vec<String> internally) and check against it every other change to update the default status.

I may create a PR with an implementation of this feature, if the idea looks good. Please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant