Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

null safety support #147

Open
modekano opened this issue Mar 9, 2021 · 12 comments
Open

null safety support #147

modekano opened this issue Mar 9, 2021 · 12 comments

Comments

@modekano
Copy link

modekano commented Mar 9, 2021

4.1.7 is not support null safety! after upgrade to flutter 2.0.1 this package show error regarding null safety

@davemg3
Copy link

davemg3 commented Mar 15, 2021

Hello,

Indeed...
@humazed , could you update your dependencies?

Because google_map_location_picker >=4.1.3 depends on geolocator ^6.1.14 which depends on geolocator_platform_interface ^1.0.8, google_map_location_picker >=4.1.3 requires geolocator_platform_interface ^1.0.8.
And because geolocator_platform_interface <2.0.0-nullsafety.0 depends on plugin_platform_interface ^1.0.2, google_map_location_picker >=4.1.3 requires plugin_platform_interface ^1.0.2.
And because cloud_firestore >=1.0.0 depends on cloud_firestore_platform_interface ^4.0.0 which depends on plugin_platform_interface ^2.0.0, google_map_location_picker >=4.1.3 is incompatible with cloud_firestore >=1.0.0.
So, because bubble_pro depends on both cloud_firestore ^1.0.0 and google_map_location_picker ^4.1.7, version solving failed.
pub get failed (1; So, because bubble_pro depends on both cloud_firestore ^1.0.0 and google_map_location_picker ^4.1.7, version solving failed.)

@modekano
Copy link
Author

I update all dependencies, but still it show error in /google_map_location_picker/lib/ code, all errors regarding null value checking.

@davemg3
Copy link

davemg3 commented Mar 15, 2021

For now, i have forked it and updated Geolocator methods as required by Geolocation 7.0.0.

For example methods checkPermission() or getCurrentPosition() became Geolocator.checkPermission() or Geolocator.getCurrentPosition()
You can see it in https://github.com/davemg3/google_map_location_picker.git file : lib/src/google_map_location_picker.dart
It is enough for me compiling with latest dependencies integrating nullsafety.

Temporary solution : Waiting for owner to update its project.

@KgotsoK
Copy link

KgotsoK commented Mar 17, 2021

@davemg3 Please create a pull request so we can review?

@jlnrrg
Copy link

jlnrrg commented Apr 10, 2021

I just took a look at a possible port and even tough @davemg3 already started, there is still a lot to do and also decisions to be made which var to still be nulllable etc.
So, @humazed if you could take a look that would be awesome.

@OrionWambert
Copy link

Any news please ?

@KgotsoK
Copy link

KgotsoK commented May 10, 2021

I think we can safely assume that this package is dead.

@blbhargav
Copy link

+1

@blbhargav
Copy link

blbhargav commented Jun 22, 2021

I forked this project and upgraded to null safety. Use this as your dependency.

google_map_location_picker:
    git:
      url: https://github.com/blbhargav/google_map_location_picker.git
      ref: null_safety

I also made a pull request. #167

@Srini-B
Copy link

Srini-B commented Sep 16, 2021

For now, i have forked it and updated Geolocator methods as required by Geolocation 7.0.0.

For example methods checkPermission() or getCurrentPosition() became Geolocator.checkPermission() or Geolocator.getCurrentPosition()
You can see it in davemg3/google_map_location_picker.git file : lib/src/google_map_location_picker.dart
It is enough for me compiling with latest dependencies integrating nullsafety.

Temporary solution : Waiting for owner to update its project.

@davemg3 can I trouble you to update it to embedding v2 if possible

@DanielSmith1239
Copy link

+1

@rvndsngwn
Copy link

I released https://pub.dev/packages/map_location_picker with fixed null safety.
Could you check that everything works for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants