Allow newer hspec, free #1690
Allow newer hspec, free #1690
Conversation
|
@maksbotan Would it be possible for you to revise servant-client-core-0.20's upper free bound? Then we could get the client back into Nightly. |
|
@ysangkok sure, done! do other packages have to be revised as well? |
|
Thank you! It's not strictly necessary to bump all packages, as hspec is only for running tests. But if you like, you can bump all these hspec bounds, and then Nightly users will be able to run the test suites. |
|
afair, stackage runs tests when building lts, so I will make those revisions. later this day wonder if that can be automated 🤔 |
| @@ -35,7 +35,7 @@ library | |||
| build-depends: | |||
| base >= 4.10 && < 4.19 | |||
| , containers >= 0.6 && < 0.7 | |||
| , aeson >= 1.3.1.1 && < 3 | |||
| , aeson >= 2.0 && < 3 | |||
There was a problem hiding this comment.
@ysangkok is this really necessary?
There was a problem hiding this comment.
the version of jose we use doesn't permit aeson 1.x. So I think it is better to set the tighten the bound here to reflect what can actually be chosen. So no, it is not necessary, but having 1.3.1.1 is confusing, and therefore I think we should get rid of it.
|
I've revised (hopefully) everything on Hackage except |
Especially the free bound is important for inclusion into Stackage Nightly.
I have also bumped the min bound for servant-auth, since jose-0.10 requires aeson-2, we might as well.
Also included is a bump for monad-time.