Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove minmaxwh ? #460

Closed
coliff opened this issue Mar 6, 2019 · 3 comments
Closed

Remove minmaxwh ? #460

coliff opened this issue Mar 6, 2019 · 3 comments
Assignees
@mischah
Labels
change-request pull-request-welcome

Comments

@coliff
Copy link
Member

coliff commented Mar 6, 2019

I suggest to remove min/max-width/height section altogether. It has 99.99% browser coverage (of tracked browsers) and has been supported since IE7. I think it's so obvious it's safe to use that it isn't needed on the site.
REF: https://caniuse.com/#feat=minmaxwh
@mischah mischah closed this as completed Mar 6, 2019
@mischah mischah reopened this Mar 6, 2019
@mischah
Copy link
Member

mischah commented Mar 6, 2019

Yep. Good catch 👌🏼
Relates to #409

@mischah
Copy link
Member

mischah commented Mar 7, 2019

Hej @coliff, are you going to do tackle this?

Otherwise I would assign this issue to myself 😗

@coliff
Copy link
Member Author

coliff commented Mar 7, 2019

I don't mind either way - pls feel free to do it if you like.

@mischah mischah self-assigned this Mar 7, 2019
mischah added a commit that referenced this issue Mar 7, 2019
@mischah
Remove min/max-width/height
e8f93fe 
Closes: #460
This was referenced Mar 7, 2019
Merged
Open
mischah added a commit that referenced this issue Mar 7, 2019
@mischah
Remove min/max-width/height
2c14488 
Closes: #460
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mischah mischah

Labels
change-request pull-request-welcome
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mischah @coliff