Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicks between spans will mess up router with escape key #277

Open
lforst opened this issue Dec 18, 2023 · 1 comment
Open

Clicks between spans will mess up router with escape key #277

lforst opened this issue Dec 18, 2023 · 1 comment
Labels
Type: Bug-confirmed Something isn't working

Comments

@lforst
Copy link
Member

lforst commented Dec 18, 2023

I clicked between spans and then pressed ESC and it moved me between the spans again. Ideally, we close the drawer if esc is pressed.

Screen.Recording.2023-12-18.at.16.41.31.mov
@lforst lforst added the Type: Bug-confirmed Something isn't working label Dec 18, 2023
@Shubhdeep12
Copy link
Collaborator

Hi @lforst
the reason why clicking the escape spandetails sidepanel is not closing is that it's a route (/traces/:traceId/:spanId)and in the spotlight when escape is clicked, we navigate to the previous route in history.

the solution which we can implement here is to remove the spanId from the route(not treating the sidepanel as a page) and open the sidepanel based on the active span state.

Also, with this commit - 14eadb9
we added a UX of treating sidepanel as a dialogue box in which on clicking outside of panel close the sidepanel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug-confirmed Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants