Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sample swaps: OutriderDataSet(countData=cts, colData=anno) makes undocumented(?) assumption that "cts" columns have same order as "anno" rows, leading to results with incorrect sample labels when this is not met. #32

Open
bw2 opened this issue Feb 10, 2021 · 0 comments

Comments

@bw2
Copy link

bw2 commented Feb 10, 2021

It's easy to create an OutriderDataSet with a countData matrix which has its columns in a different order than rows in the colData table. However, this leads to incorrectly assigned sample labels in the results.
If OutriderDataSet could internally do

cts = cts[,anno$sampleID]

or throw an error when the order doesn't match, it would prevent hard-to-detect sample swaps in the results.

@bw2 bw2 changed the title Silent sample swaps: OutriderDataSet(countData=cts, colData=anno) makes undocumented(?) assumption that "cts" columns have same order as "anno" rows, leading to sample swaps when this is not met. sample swaps: OutriderDataSet(countData=cts, colData=anno) makes undocumented(?) assumption that "cts" columns have same order as "anno" rows, leading to results with incorrect sample labels when this is not met. Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant