Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic import #37

Open
adamgins opened this issue Nov 14, 2021 · 4 comments
Open

Dynamic import #37

adamgins opened this issue Nov 14, 2021 · 4 comments

Comments

@adamgins
Copy link

adamgins commented Nov 14, 2021

Hi there, there Froala editor awesome but it's pretty large, ~900KB, and is included in the bundle, which slows things down significantly.

We'd like to make this a dynamic import https://docs.meteor.com/packages/dynamic-import.html so it's only imported when it loads, thus significantly reducing bundle size.

I am not sure if there is a way we can do this with the current version or if that's a feature request?

@adamgins
Copy link
Author

@adamgins
Copy link
Author

Is there any response on this - we're at a point where we may need to move away from this package due to this issue

there are some possible easy fixes. I contacted the Meteor folk and one recommendation was

This package needs some rework, as the best would be to serve these files from the public folder only when the component loads, instead of including all these files in the bundle.

So this could be as simple as just moving/references the files from / in the /public folder. Are you able to do this or would you accept a pull request?

@adamgins
Copy link
Author

@harasunu-narayan

@adamgins
Copy link
Author

Hi any further response on this pls?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant