Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pubsub broadcast loops #576

Open
3 tasks
Stebalien opened this issue Aug 19, 2024 · 4 comments
Open
3 tasks

Fix pubsub broadcast loops #576

Stebalien opened this issue Aug 19, 2024 · 4 comments
Assignees
Labels

Comments

@Stebalien
Copy link
Member

See libp2p/go-libp2p-pubsub#573.

Tasks:

  1. Write a spec change.
  2. Implement it in go-libp2p-pubsub.
  3. Integrate into F3.
@Stebalien
Copy link
Member Author

I still really want to do this but... I'm not sure how critical it is now:

  1. We won't re-broadcast messages for at least 2m (the time cache).
  2. We expect an instance every 30s.
  3. We drop messages from prior instances.

That means this is only an issue when we have a long instance. But in that case, we kind of want to rebroadcast and, if we're worried about exponentially increasing traffic, we should probably just drop messages from old rounds instead.

@Kubuxu
Copy link
Contributor

Kubuxu commented Aug 30, 2024

It makes sense, given that we have to be able to handle the parings from N participants either way.

@Stebalien
Copy link
Member Author

Stebalien commented Aug 30, 2024 via email

@Stebalien
Copy link
Member Author

We're deferring this because it's not a priority. Instead, we're focusing on #583.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Development

No branches or pull requests

2 participants