Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Faiss][CI] Make SWIG memory errors fail the build #3762

Open
mnorris11 opened this issue Aug 15, 2024 · 0 comments
Open

[Faiss][CI] Make SWIG memory errors fail the build #3762

mnorris11 opened this issue Aug 15, 2024 · 0 comments

Comments

@mnorris11
Copy link

mnorris11 commented Aug 15, 2024

SWIG memory leaks do not fail the build, but they should. We should investigate turning this into a hard error.

See error logs in: https://gist.github.com/asadoughi/ded4ea2ad14766da4f578b560f185a1d

#3760 fixed it, so it will not reproduce now unless you undo that change locally and rerun the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants