Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SessionHandler compatibility in PHP 8 #37

Open
Mark-H opened this issue Mar 16, 2024 · 1 comment
Open

SessionHandler compatibility in PHP 8 #37

Mark-H opened this issue Mar 16, 2024 · 1 comment

Comments

@Mark-H
Copy link

Mark-H commented Mar 16, 2024

PHP 8 (not sure which minor exactly) introduced types to the SessionHandler/SessionHandlerInterface which is incompatible with the current implementation of this library.

Deprecated: Return type of PHPSecureSession\SecureHandler::open($save_path, $session_name) should either be compatible with SessionHandler::open(string $path, string $name): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in vendor/ezimuel/php-secure-session/src/SecureHandler.php on line 49
PHP Deprecated:  Return type of PHPSecureSession\SecureHandler::read($id) should either be compatible with SessionHandler::read(string $id): string|false, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in ezimuel/php-secure-session/src/SecureHandler.php on line 60

There is a fork here where @DatabayAG already applied the necessary changes, but it doesn't look like they created a PR.

@ezimuel
Copy link
Owner

ezimuel commented Mar 27, 2024

Thanks @Mark-H I'll check the code. Yes , this library needs more love and some updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants