Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hanami: non-integer path variable is not supported #227

Closed
exoego opened this issue Apr 22, 2024 · 2 comments
Closed

hanami: non-integer path variable is not supported #227

exoego opened this issue Apr 22, 2024 · 2 comments
Labels
bug Something isn't working help wanted Extra attention is needed not this repo The issue is caused in Ruby or other dependencies
Milestone
v0.18.3

Comments

@exoego
Copy link
Owner

exoego commented Apr 22, 2024

While I was working in #226, I noticed that Hanami support is broken.
It can not handle non-numeric path variable like /sites/{name} where name can be foo or bar.

I think it is an upstream issue in Hanami side, and reported in Hanami router: hanami/router#271
@exoego exoego changed the title hanami: hanami: non-integer path variable is not supported Apr 22, 2024
@exoego exoego added bug Something isn't working not this repo The issue is caused in Ruby or other dependencies labels Apr 22, 2024
@exoego exoego mentioned this issue Apr 22, 2024
Closed
@exoego exoego added the help wanted Extra attention is needed label Apr 22, 2024
@AlexeyMatskevich
Copy link
Contributor

Confirming the problem

@exoego exoego mentioned this issue Apr 30, 2024
Merged
@exoego
Copy link
Owner Author

exoego commented May 1, 2024

Closed by #231

@exoego exoego closed this as completed May 1, 2024
@exoego exoego added this to the vnext milestone May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed not this repo The issue is caused in Ruby or other dependencies
Projects
None yet
Milestone
v0.18.3
Development

No branches or pull requests
2 participants
@exoego @AlexeyMatskevich