From 87fc7ea812edc14cbfd1de6c85a4d9892391b462 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?TATSUNO=20=E2=80=9CTaz=E2=80=9D=20Yasuhiro?= Date: Wed, 17 Apr 2024 09:36:41 +0900 Subject: [PATCH] Style/MapIntoArray: Use map instead of each to map elements into an array. (#214) --- lib/rspec/openapi/schema_builder.rb | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/lib/rspec/openapi/schema_builder.rb b/lib/rspec/openapi/schema_builder.rb index 45ca8f6..49b5272 100644 --- a/lib/rspec/openapi/schema_builder.rb +++ b/lib/rspec/openapi/schema_builder.rb @@ -64,10 +64,8 @@ def example_enabled? end def build_parameters(record) - parameters = [] - - record.path_params.each do |key, value| - parameters << { + path_params = record.path_params.map do |key, value| + { name: build_parameter_name(key, value), in: 'path', required: true, @@ -76,8 +74,8 @@ def build_parameters(record) }.compact end - record.query_params.each do |key, value| - parameters << { + query_params = record.query_params.map do |key, value| + { name: build_parameter_name(key, value), in: 'query', required: record.required_request_params.include?(key), @@ -86,8 +84,8 @@ def build_parameters(record) }.compact end - record.request_headers.each do |key, value| - parameters << { + header_params = record.request_headers.map do |key, value| + { name: build_parameter_name(key, value), in: 'header', required: true, @@ -96,6 +94,8 @@ def build_parameters(record) }.compact end + parameters = path_params + query_params + header_params + return nil if parameters.empty? parameters