Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Which layer should implement the check of whether a round can be finalized? #85

Open
fjarri opened this issue Nov 22, 2023 · 0 comments
Labels
API Involves backwards-incompatible changes of the public API
Milestone

Comments

@fjarri
Copy link
Member

fjarri commented Nov 22, 2023

The current implementation is at the type erased level (DynRoundAccum) where we just check if all the non-None accumulators are filled. Perhaps it is more logical for it to be located at the same level as finalize*() methods, that is at the typed level. This will require some kind of generic code so that we don't have to repeat it in every round.

@fjarri fjarri added the API Involves backwards-incompatible changes of the public API label Nov 22, 2023
@fjarri fjarri added this to the v1.0.0 milestone Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Involves backwards-incompatible changes of the public API
Projects
None yet
Development

No branches or pull requests

1 participant