From a7370def79cc0a580f74cf1892756f7413f90f31 Mon Sep 17 00:00:00 2001 From: Enrico Zimuel Date: Tue, 19 Dec 2023 14:12:33 +0100 Subject: [PATCH 1/2] Fixed link in breaking changes doc --- docs/breaking-changes.asciidoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/breaking-changes.asciidoc b/docs/breaking-changes.asciidoc index 3544b92ad..04d666c2d 100644 --- a/docs/breaking-changes.asciidoc +++ b/docs/breaking-changes.asciidoc @@ -36,7 +36,7 @@ The following functions has been removed: - `ClientBuilder::setTracer()`, you can only set a Logger using `ClientBuilder::setLogger()` - `ClientBuilder::setSerializer()` - `ClientBuilder::setConnectionParams()`, you can use `ClientBuilder::setHttpClientOptions()` instead -- `ClientBuilder::setSelector()`, you can set a `Selector` using the `setNodePool`, see [here](https://github.com/elastic/elastic-transport-php/blob/8.x/README.md#use-a-custom-selector) for more information +- `ClientBuilder::setSelector()`, you can set a `Selector` using the `setNodePool`, see https://github.com/elastic/elastic-transport-php/blob/8.x/README.md#use-a-custom-selector[here]( for more information - `ClientBuilder::setSniffOnStart()` - `ClientBuilder::includePortInHostHeader()` From 1ba816abe385c7553f619af4712c1af6bbf37502 Mon Sep 17 00:00:00 2001 From: Enrico Zimuel Date: Wed, 24 Jan 2024 10:04:53 +0100 Subject: [PATCH 2/2] Fix typo in doc --- docs/breaking-changes.asciidoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/breaking-changes.asciidoc b/docs/breaking-changes.asciidoc index 04d666c2d..7bbd4f8d9 100644 --- a/docs/breaking-changes.asciidoc +++ b/docs/breaking-changes.asciidoc @@ -36,7 +36,7 @@ The following functions has been removed: - `ClientBuilder::setTracer()`, you can only set a Logger using `ClientBuilder::setLogger()` - `ClientBuilder::setSerializer()` - `ClientBuilder::setConnectionParams()`, you can use `ClientBuilder::setHttpClientOptions()` instead -- `ClientBuilder::setSelector()`, you can set a `Selector` using the `setNodePool`, see https://github.com/elastic/elastic-transport-php/blob/8.x/README.md#use-a-custom-selector[here]( for more information +- `ClientBuilder::setSelector()`, you can set a `Selector` using the `setNodePool`, see https://github.com/elastic/elastic-transport-php/blob/8.x/README.md#use-a-custom-selector[here] for more information - `ClientBuilder::setSniffOnStart()` - `ClientBuilder::includePortInHostHeader()`