Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4 Deprecations in ClientBuilder #1413

Open
TimWolla opened this issue Sep 13, 2024 · 0 comments
Open

PHP 8.4 Deprecations in ClientBuilder #1413

TimWolla opened this issue Sep 13, 2024 · 0 comments

Comments

@TimWolla
Copy link

Using elasticsearch-php in PHP 8.4 emits 3 deprecation notices when loading ClientBuilder, due to the https://wiki.php.net/rfc/deprecate-implicitly-nullable-types RFC:

Deprecated: Elastic\Elasticsearch\ClientBuilder::setApiKey(): Implicitly marking parameter $id as nullable is deprecated, the explicit nullable type must be used instead in src/ClientBuilder.php on line 229

Deprecated: Elastic\Elasticsearch\ClientBuilder::setSSLCert(): Implicitly marking parameter $password as nullable is deprecated, the explicit nullable type must be used instead in src/ClientBuilder.php on line 275

Deprecated: Elastic\Elasticsearch\ClientBuilder::setSSLKey(): Implicitly marking parameter $password as nullable is deprecated, the explicit nullable type must be used instead in src/ClientBuilder.php on line 298

As far as I can tell there are no other issues with elasticsearch-php itself when running the test suite using PHP 8.4. Only the php-http/mock-client dependency reports a similar deprecation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant