-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Updatecli seems flaky #2158
Comments
I accidentally saw this issue and couldn't resist having a look.
The default behavior for the shell plugin is to trigger a target "changed" if something was printed on the console output. In this pipeline the target is always flagged as "changed" which triggers a git commit and report an issue when no file need to be committed So the target
could probably be improved to
Note that instead of using "file/checksum" it is also possible to use "exitcode" with something like
I still behind in terms of documentation and still need to document those feature on the updatecli.io documentation |
Thanks @olblak that's nice to know. Ending our scripts with
should probably work good enough for us. Just to clarify, |
Reading your question make me realize that it's not clear enough. "Failure" means something went wrong during the shell execution, like running out of disk space We have an open issue as we would like to clarify the different exit code cfr updatecli/updatecli#233 |
So, for our use case can we not do
to mean "files changed if script's exit code is 0, nothing changed if exit code is 1"? I am referring to this part of your comment above:
|
Describe the bug
UpdateCLI workflows seem flaky and fail most of the time they run.
We should investigate why and how to improve that.
Optionally, we could consider removing the overlap between UpdateCLI (Golang Mod job) and dependabot.The text was updated successfully, but these errors were encountered: