Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When a direct link is taken via an annotation, cue the video to that point #49

Open
dwhly opened this issue Oct 16, 2020 · 2 comments
Open

Comments

@dwhly
Copy link
Collaborator

dwhly commented Oct 16, 2020

If you follow this link:

https://hyp.is/MKXJlg9aEeurAy8NWpahjQ/docdrop.org/video/XqxwwuUdsp4/

It doesn't cue the video to that point. Could it?

@genuineBuildMonkey
Copy link
Collaborator

Good question. Let me try.

@genuineBuildMonkey
Copy link
Collaborator

This should be possible but the trouble I've run into is determining if the script is running in a share link rather then natively.

It looks like via.hypothes.is caches the javascript and overwrites window.href references in the script with references to the internal document. Thinking about how to bypass that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants