Many warnings in XCode 9.0 when running the static analyzer (Product > Analyze)

[yoasha]

The following warning appears in many files:
Converting a pointer value of type 'NSNumber * _Nullable' to a primitive boolean value; instead, either compare the pointer to nil or call -boolValue

[yoasha]

[greg-db]

Thanks for the report! I'll ask the team to get this cleaned up.

[yoasha]

Running the static analyzer with latest version of Xcode (9.3) and latest version of Dropbox SDK via cocoapods (3.8.1 release) still generates many warnings that can potentially lead to bugs... (the code is checking for example for a positive value in NSNumber rather than in [NSNumber booleanValue]).

Can you produce these warnings on your side?

[scobbe]

@yoasha: I'm not able to reproduce this on my end. Can you give a specific example of the warnings you're seeing?

I see a few places where we're missing != nil which isn't ideal, but I don't see any boolean correctness issues.

[yoasha]

File:
/Pods/ObjectiveDropboxOfficial/Source/ObjectiveDropboxOfficial/Shared/Generated/ApiObjects/FileRequests/DBFileRequestsObjects.m:2231:7:

Method:
(BOOL)isEqualToUpdateFileRequestArgs:

Warning:
Converting a pointer value of type 'NSNumber * _Nullable' to a primitive boolean value; instead, either compare the pointer to nil or call -boolValue

Screenshot attached.

[yoasha]

Sorry, I closed this issue by mistake.... I reopened it and added updated screenshot and warning details as requested.

[greg-db]

Thanks for the additional information!

[yoasha]

Can you reproduce it in your environment? Or is it a cocoa-pods config issue on my end that prevents me getting the latest and fixed code?

[greg-db]

I just tried it, and I'm not able to reproduce it either. Do you have any non-default settings that may affect this?

It appears you have the latest version of the code. If pod update failed, you should see an error when you run it anyway.

[yoasha]

I just looked into the source code directly on github and also confirmed that I have the latest code.

As far as I know, I have the default settings. Did you try to compile your project or did you explicitly select Xcode > Product > Analyze? Note that with standard compile the warnings are not appearing for me, but only when selecting the "Analyze" command.

Also note the following:

• In the method isEqualToUpdateFileRequestArgs there is a code of if (self.open). However, the open property is defined as NSNumber *, so the analyzer warning (regardless of any environment configuration) is correctly alerting for a potential bug.

IMHO, the correct code regardless of any warnings appearing on Xcode would be if (self.open.boolValue)

This of course applies to all instances of this issue and not only to this method.

[greg-db]

Thanks! Yes, I tried Product > Analyze specifically.

Anyway, this is open with the team. We'll follow up if/when we have an update for this.

[scobbe]

@yoasha: The if (self.open) check in isEqualToUpdateFileRequestArgs is for nullability, not for a boolean value.

But of course if (self.open != nil) would be better. I'll try and fix it when I get the chance.

[yoasha]

@scobbe : thanks for clarifying that check is for nullability. Changing this to if (self.open != nil) would surely remove some confusion.