Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: MSBuild packages 17.3.4 not published on nuget.org #10492

Open
tmat opened this issue Aug 6, 2024 · 8 comments
Open

[Bug]: MSBuild packages 17.3.4 not published on nuget.org #10492

tmat opened this issue Aug 6, 2024 · 8 comments
Labels
bug needs-more-info Issues that need more info to continue investigation. stale For issues that haven't had activity in some time. triaged

Comments

@tmat
Copy link
Member

tmat commented Aug 6, 2024

Expected Behavior

Packages should be published

Actual Behavior

Packages not published

@tmat tmat added the bug label Aug 6, 2024
@baronfel
Copy link
Member

baronfel commented Aug 6, 2024

Those are pretty old - where is this dependency version coming from?

@tmat
Copy link
Member Author

tmat commented Aug 6, 2024

That's the version that source build requires.

@tmat
Copy link
Member Author

tmat commented Aug 6, 2024

See https://github.com/dotnet/roslyn/blob/main/eng/Directory.Packages.props#L28-L53

@maridematte
Copy link
Contributor

It seems that this was a change in main from sometime ago: dotnet/roslyn#73283. The problem of the package not being published was discussed on the PR. Has anything else changed recently that could cause this issue?

@maridematte maridematte added the needs-more-info Issues that need more info to continue investigation. label Aug 13, 2024
@ViktorHofer
Copy link
Member

ViktorHofer commented Aug 20, 2024

That's the version that source build requires.

Source-build doesn't require that old version of MSBuild. Any package version that exists in SBRP is fine. You can use a newer version of MSBuild dependencies. I.e. 17.8.3 is available on SBRP: https://github.com/dotnet/source-build-reference-packages/tree/main/src/referencePackages/src/microsoft.build

@ViktorHofer
Copy link
Member

cc @dotnet/source-build-internal

@ellahathaway
Copy link
Member

ellahathaway commented Aug 20, 2024

That's the version that source build requires.

Source-build doesn't require that old version of MSBuild. Any package version that exists in SBRP is fine. You can use a newer version of MSBuild dependencies. I.e. 17.8.3 is available on SBRP: https://github.com/dotnet/source-build-reference-packages/tree/main/src/referencePackages/src/microsoft.build

This is correct. Based on this comment, I would not expect this package to be published on nuget.org. The package should be being pulled from SBRP.

@dotnet-policy-service dotnet-policy-service bot added the stale For issues that haven't had activity in some time. label Sep 19, 2024
Copy link
Contributor

This issue is marked as stale because feedback has been requested for 30 days with no response. Please respond within 14 days or this issue will be closed due to inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug needs-more-info Issues that need more info to continue investigation. stale For issues that haven't had activity in some time. triaged
Projects
None yet
Development

No branches or pull requests

5 participants