Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an "AcceptEula" API to containers that use environment variables to signal EULA acceptance. #5727

Open
mitchdenny opened this issue Sep 16, 2024 · 5 comments
Labels
area-integrations Issues pertaining to Aspire Integrations packages breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. enhancement An enhancement to an existing feature or capability. sqlserver Issues related to SQLServer integrtions
Milestone

Comments

@mitchdenny
Copy link
Member

Some containers have a EULA acceptance process where you add an environment variable. Rather than adding these environment variables automatically we should provide a mechanism for developers to explicitly opt into this. This means that their first run of a particular resource will likely fail, they'll get an error and then apply another method. Here is an example of how it could work:

Container resource example

builder.AddSqlServer("sql")
       .WithAcceptEula(true);

Related resource example

builder.AddRedis("redis")
       .WithRedisInsights(c => c.WithAcceptEula(true));
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Sep 16, 2024
@mitchdenny mitchdenny added area-integrations Issues pertaining to Aspire Integrations packages and removed area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication labels Sep 16, 2024
@mitchdenny mitchdenny added this to the 9.0 milestone Sep 16, 2024
@mitchdenny
Copy link
Member Author

related: #5227

@davidfowl davidfowl added the breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. label Sep 16, 2024
@davidfowl
Copy link
Member

Do we know that it's the first run that fails? Today we auto accept the eula for Seq and SqlServer. These need to be undone and it has to be opted into by customers.

@mitchdenny
Copy link
Member Author

I think in the case on SQL it means every run where that environment variable isn't present.

@davidfowl davidfowl added the enhancement An enhancement to an existing feature or capability. label Sep 16, 2024
@Alirexaa
Copy link
Contributor

related: #5227

Do you think we should apply this one in related PR? or can be a follow up?

@davidfowl
Copy link
Member

I think we should not auto accept the Eula in the redis insight PR

@davidfowl davidfowl added the sqlserver Issues related to SQLServer integrtions label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-integrations Issues pertaining to Aspire Integrations packages breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. enhancement An enhancement to an existing feature or capability. sqlserver Issues related to SQLServer integrtions
Projects
None yet
Development

No branches or pull requests

3 participants