Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Podman testing in CI #5689

Open
mitchdenny opened this issue Sep 12, 2024 · 2 comments
Open

Podman testing in CI #5689

mitchdenny opened this issue Sep 12, 2024 · 2 comments

Comments

@mitchdenny
Copy link
Member

mitchdenny commented Sep 12, 2024

Is now a good time to discuss Podman testing? At the moment all of our testing is done against Docker/Docker Desktop, but we say we support Podman but don't do any validation in our CI.

Originally posted by @mitchdenny in #5628 (comment)

At the moment we allow developers to select between Docker/Docker Desktop and Podman for container runtime support. However in our CI tests we only ever use Docker Desktop and I'd say 90% of our team uses Docker Desktop rather than Podman on a daily basis (the DCP folks probably swap between them a bit more than we do).

There are so many issues that we get filed where there are subtle compatibility issues/differences between Docker Desktop and Podman. A lot of these fall into container networking differences and we are making some investments there around setting up container networks (see: #5628).

This issue is more around how we can improve our test coverage for Podman moving forward. I think there are a few problems to solve here:

  1. If we add test coverage for Podman (e.g. switch [Fact] to [Theory] to swapping container runtimes in tests) then developers will need to have both installed.
  2. We will need Podman on build machines/helix agents.

We probably don't need to duplicate tests for both runtimes everywhere, there are probably just some key feature areas that we know need some coverage.

@mitchdenny mitchdenny added area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication area-engineering-systems area-orchestrator and removed area-dashboard labels Sep 12, 2024
@mitchdenny mitchdenny added this to the Backlog milestone Sep 12, 2024
@mitchdenny
Copy link
Member Author

@danegsta
Copy link
Member

We could do two separate parallel test runs; one on a machine with Docker installed and the other on a machine with Podman. I've tried running some of the tests with just Podman Desktop active and they seem to mostly work.

@davidfowl davidfowl added testing ☑️ area-engineering-systems and removed area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication area-engineering-systems area-orchestrator testing ☑️ labels Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants