Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align SignTool MSBuild Usage on Windows with Current Execution Environment #15046

Open
Tracked by #3708
ellahathaway opened this issue Sep 4, 2024 · 2 comments
Open
Tracked by #3708

Comments

@ellahathaway
Copy link
Member

From this line:

<_DesktopMSBuildRequired Condition="'$(_DryRun)' != 'true' and '$(MSBuildRuntimeType)' == 'Core'  and '$(OS)' == 'Windows_NT'">true</_DesktopMSBuildRequired>

We are currently using desktop msbuild when running on Windows with .NET core. After we have validated that using .NET Core MSBuild on other OSes does not negatively impact the usage of SignTool, we should change the default on windows to be what is currently executing. That is, if we're already on core, we shouldn't require desktop msbuild.

Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

1 similar comment
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

1 participant