Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When NetPrevious is set to empty, some projects have unexpected behavior #14768

Open
2 tasks
Tracked by #2975
mmitche opened this issue May 15, 2024 · 2 comments
Open
2 tasks
Tracked by #2975

Comments

@mmitche
Copy link
Member

mmitche commented May 15, 2024

  • This issue is blocking
  • This issue is causing unreasonable pain

When NetPrevious and NetMinimum are the same, the current behavior is to null out NetPrevious. This avoids duplicate-TFM conflicts for projects that target both NetPrevious and NetMinimum. The bad news is that this will cause errors for single-targeted projects that just target NetPrevious. It's worse new for projects that multi-target target NetPrevious and NetCurrent/some other non NetMinimum TFM.

A solution here is that:

  • NetPrevious should always be set
  • The only set of properties you can always combine are NetPrevious and NetCurrent
  • A property should be introduced that is the union of NetPrevious and NetMinimum.
@mmitche
Copy link
Member Author

mmitche commented May 15, 2024

/cc @ViktorHofer @jaredpar @akoeplinger

@jaredpar
Copy link
Member

A property should be introduced that is the union of NetPrevious and NetMinimum.

I think this is the key. Given that NetPrevious and NetCurrent can change, and will change in various builds, there is no safe way to combine them with other properties. They can be safely combined with each other but no one else.

For the combinations of NetPrevious/NetCurrent and other Net propreties that we want to support we should have a named property defined that safely combines them.

@missymessa missymessa added this to the Tracking for other teams milestone Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants