From 1fa1df89dd812cddbc71cb6e802b83feae3c0803 Mon Sep 17 00:00:00 2001
From: koy <koy@ko8e24.top>
Date: Tue, 30 Jul 2024 19:30:02 +0800
Subject: [PATCH 1/4] chore: polish code

---
 src/core/render/compiler.js          | 94 ++++------------------------
 src/core/render/compiler/headling.js | 31 +++++++++
 src/core/render/compiler/media.js    | 42 +++++++++++++
 src/core/render/index.js             | 17 ++---
 src/core/router/history/hash.js      |  2 +-
 src/core/util/dom.js                 | 13 ++++
 6 files changed, 104 insertions(+), 95 deletions(-)
 create mode 100644 src/core/render/compiler/headling.js
 create mode 100644 src/core/render/compiler/media.js

diff --git a/src/core/render/compiler.js b/src/core/render/compiler.js
index d01e65aea..76266a2f1 100644
--- a/src/core/render/compiler.js
+++ b/src/core/render/compiler.js
@@ -5,63 +5,18 @@ import { tree as treeTpl } from './tpl.js';
 import { genTree } from './gen-tree.js';
 import { slugify } from './slugify.js';
 import { emojify } from './emojify.js';
-import {
-  getAndRemoveConfig,
-  removeAtag,
-  getAndRemoveDocsifyIgnoreConfig,
-} from './utils.js';
+import { getAndRemoveConfig } from './utils.js';
 import { imageCompiler } from './compiler/image.js';
+import { headingCompiler } from './compiler/headling.js';
 import { highlightCodeCompiler } from './compiler/code.js';
 import { paragraphCompiler } from './compiler/paragraph.js';
 import { taskListCompiler } from './compiler/taskList.js';
 import { taskListItemCompiler } from './compiler/taskListItem.js';
 import { linkCompiler } from './compiler/link.js';
+import { compileMedia } from './compiler/media.js';
 
 const cachedLinks = {};
 
-const compileMedia = {
-  markdown(url) {
-    return {
-      url,
-    };
-  },
-  mermaid(url) {
-    return {
-      url,
-    };
-  },
-  iframe(url, title) {
-    return {
-      html: `<iframe src="${url}" ${
-        title || 'width=100% height=400'
-      }></iframe>`,
-    };
-  },
-  video(url, title) {
-    return {
-      html: `<video src="${url}" ${title || 'controls'}>Not Support</video>`,
-    };
-  },
-  audio(url, title) {
-    return {
-      html: `<audio src="${url}" ${title || 'controls'}>Not Support</audio>`,
-    };
-  },
-  code(url, title) {
-    let lang = url.match(/\.(\w+)$/);
-
-    lang = title || (lang && lang[1]);
-    if (lang === 'md') {
-      lang = 'markdown';
-    }
-
-    return {
-      url,
-      lang,
-    };
-  },
-};
-
 export class Compiler {
   constructor(config, router) {
     this.config = config;
@@ -173,7 +128,7 @@ export class Compiler {
           type = 'audio';
         }
 
-        embed = compileMedia[type].call(this, href, title);
+        embed = compileMedia[type](href, title);
         embed.type = type;
       }
 
@@ -198,47 +153,22 @@ export class Compiler {
   _initRenderer() {
     const renderer = new marked.Renderer();
     const { linkTarget, linkRel, router, contentBase } = this;
-    const _self = this;
+    // Supports mermaid
     const origin = {};
 
-    /**
-     * Render anchor tag
-     * @link https://github.com/markedjs/marked#overriding-renderer-methods
-     * @param {String} tokens the content tokens
-     * @param {Number} depth Type of heading (h<level> tag)
-     * @returns {String} Heading element
-     */
-    origin.heading = renderer.heading = function ({ tokens, depth }) {
-      const text = this.parser.parseInline(tokens);
-      let { str, config } = getAndRemoveConfig(text);
-      const nextToc = { depth, title: str };
-
-      const { content, ignoreAllSubs, ignoreSubHeading } =
-        getAndRemoveDocsifyIgnoreConfig(str);
-      str = content.trim();
-
-      nextToc.title = removeAtag(str);
-      nextToc.ignoreAllSubs = ignoreAllSubs;
-      nextToc.ignoreSubHeading = ignoreSubHeading;
-      const slug = slugify(config.id || str);
-      const url = router.toURL(router.getCurrentPath(), { id: slug });
-      nextToc.slug = url;
-      _self.toc.push(nextToc);
-
-      // Note: tabindex="-1" allows programmatically focusing on heading
-      // elements after navigation. This is preferred over focusing on the link
-      // within the heading because it matches the focus behavior of screen
-      // readers when navigating page content.
-      return `<h${depth} id="${slug}" tabindex="-1"><a href="${url}" data-id="${slug}" class="anchor"><span>${str}</span></a></h${depth}>`;
-    };
-
+    // renderer customizers
+    origin.heading = headingCompiler({
+      renderer,
+      router,
+      compilerClass: this,
+    });
     origin.code = highlightCodeCompiler({ renderer });
     origin.link = linkCompiler({
       renderer,
       router,
       linkTarget,
       linkRel,
-      compilerClass: _self,
+      compilerClass: this,
     });
     origin.paragraph = paragraphCompiler({ renderer });
     origin.image = imageCompiler({ renderer, contentBase, router });
diff --git a/src/core/render/compiler/headling.js b/src/core/render/compiler/headling.js
new file mode 100644
index 000000000..c32b9044d
--- /dev/null
+++ b/src/core/render/compiler/headling.js
@@ -0,0 +1,31 @@
+import {
+  getAndRemoveConfig,
+  removeAtag,
+  getAndRemoveDocsifyIgnoreConfig,
+} from '../utils.js';
+import { slugify } from './../slugify.js';
+
+export const headingCompiler = ({ renderer, router, compilerClass }) =>
+  (renderer.heading = function ({ tokens, depth }) {
+    const text = this.parser.parseInline(tokens);
+    let { str, config } = getAndRemoveConfig(text);
+    const nextToc = { depth, title: str };
+
+    const { content, ignoreAllSubs, ignoreSubHeading } =
+      getAndRemoveDocsifyIgnoreConfig(str);
+    str = content.trim();
+
+    nextToc.title = removeAtag(str);
+    nextToc.ignoreAllSubs = ignoreAllSubs;
+    nextToc.ignoreSubHeading = ignoreSubHeading;
+    const slug = slugify(config.id || str);
+    const url = router.toURL(router.getCurrentPath(), { id: slug });
+    nextToc.slug = url;
+    compilerClass.toc.push(nextToc);
+
+    // Note: tabindex="-1" allows programmatically focusing on heading
+    // elements after navigation. This is preferred over focusing on the link
+    // within the heading because it matches the focus behavior of screen
+    // readers when navigating page content.
+    return `<h${depth} id="${slug}" tabindex="-1"><a href="${url}" data-id="${slug}" class="anchor"><span>${str}</span></a></h${depth}>`;
+  });
diff --git a/src/core/render/compiler/media.js b/src/core/render/compiler/media.js
new file mode 100644
index 000000000..d12b1fb0d
--- /dev/null
+++ b/src/core/render/compiler/media.js
@@ -0,0 +1,42 @@
+export const compileMedia = {
+  markdown(url) {
+    return {
+      url,
+    };
+  },
+  mermaid(url) {
+    return {
+      url,
+    };
+  },
+  iframe(url, title) {
+    return {
+      html: `<iframe src="${url}" ${
+        title || 'width=100% height=400'
+      }></iframe>`,
+    };
+  },
+  video(url, title) {
+    return {
+      html: `<video src="${url}" ${title || 'controls'}>Not Support</video>`,
+    };
+  },
+  audio(url, title) {
+    return {
+      html: `<audio src="${url}" ${title || 'controls'}>Not Support</audio>`,
+    };
+  },
+  code(url, title) {
+    let lang = url.match(/\.(\w+)$/);
+
+    lang = title || (lang && lang[1]);
+    if (lang === 'md') {
+      lang = 'markdown';
+    }
+
+    return {
+      url,
+      lang,
+    };
+  },
+};
diff --git a/src/core/render/index.js b/src/core/render/index.js
index 06f900bb7..e85a841c2 100644
--- a/src/core/render/index.js
+++ b/src/core/render/index.js
@@ -82,7 +82,7 @@ export function Render(Base) {
         }
       }
 
-      this._renderTo(markdownElm, html);
+      dom.renderTo(markdownElm, html);
 
       // Execute markdown <script>
       if (
@@ -274,13 +274,6 @@ export function Render(Base) {
       }
     }
 
-    _renderTo(el, content, replace) {
-      const node = dom.getNode(el);
-      if (node) {
-        node[replace ? 'outerHTML' : 'innerHTML'] = content;
-      }
-    }
-
     _renderSidebar(text) {
       const { maxLevel, subMaxLevel, loadSidebar, hideSidebar } = this.config;
       const sidebarEl = dom.getNode('aside.sidebar');
@@ -294,7 +287,7 @@ export function Render(Base) {
         return null;
       }
 
-      this._renderTo('.sidebar-nav', this.compiler.sidebar(text, maxLevel));
+      dom.renderTo('.sidebar-nav', this.compiler.sidebar(text, maxLevel));
 
       sidebarToggleEl.setAttribute('aria-expanded', !isMobile());
 
@@ -366,7 +359,7 @@ export function Render(Base) {
       const html = this.compiler.compile(text);
 
       ['.app-nav', '.app-nav-merged'].forEach(selector => {
-        this._renderTo(selector, html);
+        dom.renderTo(selector, html);
         this.#addTextAsTitleAttribute(`${selector} a`);
       });
     }
@@ -507,7 +500,7 @@ export function Render(Base) {
         rootElm.style.setProperty('--cover-bg', mdCoverBg);
       }
 
-      this._renderTo('.cover-main', html);
+      dom.renderTo('.cover-main', html);
 
       // Button styles
       dom
@@ -563,7 +556,7 @@ export function Render(Base) {
         html += tpl.main(config);
 
         // Render main app
-        this._renderTo(el, html, true);
+        dom.renderTo(el, html, true);
       } else {
         this.rendered = true;
       }
diff --git a/src/core/router/history/hash.js b/src/core/router/history/hash.js
index b84c8cdca..dcecf04dd 100644
--- a/src/core/router/history/hash.js
+++ b/src/core/router/history/hash.js
@@ -71,7 +71,7 @@ export class HashHistory extends History {
 
   /**
    * Parse the url
-   * @param {string} [path=location.herf] URL to be parsed
+   * @param {string} [path=location.href] URL to be parsed
    * @return {object} { path, query }
    */
   parse(path = location.href) {
diff --git a/src/core/util/dom.js b/src/core/util/dom.js
index 0715cc638..056a0d502 100644
--- a/src/core/util/dom.js
+++ b/src/core/util/dom.js
@@ -20,6 +20,19 @@ export function getNode(el, noCache = false) {
   return el;
 }
 
+/**
+ *
+ * @param {*} el the targt element or the selector
+ * @param {*} content the content to be rendered
+ * @param {*} replace To replace the content (true) or insert instead (false) , default is false
+ */
+export function renderTo(el, content, replace) {
+  const node = getNode(el);
+  if (node) {
+    node[replace ? 'outerHTML' : 'innerHTML'] = content;
+  }
+}
+
 export const $ = document;
 
 export const body = $.body;

From 5491bd27f77035f6f3488f562510a7c20136fa3d Mon Sep 17 00:00:00 2001
From: koy <koy@ko8e24.top>
Date: Tue, 30 Jul 2024 19:35:47 +0800
Subject: [PATCH 2/4] remove unused file

---
 src/core/render/compiler/headline.js | 27 ---------------------------
 1 file changed, 27 deletions(-)
 delete mode 100644 src/core/render/compiler/headline.js

diff --git a/src/core/render/compiler/headline.js b/src/core/render/compiler/headline.js
deleted file mode 100644
index 48a7c1302..000000000
--- a/src/core/render/compiler/headline.js
+++ /dev/null
@@ -1,27 +0,0 @@
-import {
-  getAndRemoveConfig,
-  removeAtag,
-  getAndRemoveDocsifyIgnoreConfig,
-} from '../utils.js';
-import { slugify } from './slugify.js';
-
-export const headingCompiler = ({ renderer, router, _self }) =>
-  (renderer.code = (text, level) => {
-    let { str, config } = getAndRemoveConfig(text);
-    const nextToc = { level, title: str };
-
-    const { content, ignoreAllSubs, ignoreSubHeading } =
-      getAndRemoveDocsifyIgnoreConfig(str);
-    str = content.trim();
-
-    nextToc.title = removeAtag(str);
-    nextToc.ignoreAllSubs = ignoreAllSubs;
-    nextToc.ignoreSubHeading = ignoreSubHeading;
-
-    const slug = slugify(config.id || str);
-    const url = router.toURL(router.getCurrentPath(), { id: slug });
-    nextToc.slug = url;
-    _self.toc.push(nextToc);
-
-    return /* html */ `<h${level} id="${slug}"><a href="${url}" data-id="${slug}" class="anchor"><span>${str}</span></a></h${level}>`;
-  });

From 09c334db88ea550675c047a30088a81ad7b99d9e Mon Sep 17 00:00:00 2001
From: koy <koy@ko8e24.top>
Date: Wed, 14 Aug 2024 21:52:38 +0800
Subject: [PATCH 3/4] update: review

---
 src/core/render/compiler.js                          |  4 ++--
 src/core/render/compiler/{headling.js => heading.js} |  6 +++---
 src/core/render/compiler/link.js                     |  8 ++++----
 src/core/render/index.js                             | 10 +++++-----
 src/core/util/dom.js                                 |  4 ++--
 5 files changed, 16 insertions(+), 16 deletions(-)
 rename src/core/render/compiler/{headling.js => heading.js} (87%)

diff --git a/src/core/render/compiler.js b/src/core/render/compiler.js
index 76266a2f1..cdce2ba32 100644
--- a/src/core/render/compiler.js
+++ b/src/core/render/compiler.js
@@ -160,7 +160,7 @@ export class Compiler {
     origin.heading = headingCompiler({
       renderer,
       router,
-      compilerClass: this,
+      compiler: this,
     });
     origin.code = highlightCodeCompiler({ renderer });
     origin.link = linkCompiler({
@@ -168,7 +168,7 @@ export class Compiler {
       router,
       linkTarget,
       linkRel,
-      compilerClass: this,
+      compiler: this,
     });
     origin.paragraph = paragraphCompiler({ renderer });
     origin.image = imageCompiler({ renderer, contentBase, router });
diff --git a/src/core/render/compiler/headling.js b/src/core/render/compiler/heading.js
similarity index 87%
rename from src/core/render/compiler/headling.js
rename to src/core/render/compiler/heading.js
index c32b9044d..5fbc81f80 100644
--- a/src/core/render/compiler/headling.js
+++ b/src/core/render/compiler/heading.js
@@ -3,9 +3,9 @@ import {
   removeAtag,
   getAndRemoveDocsifyIgnoreConfig,
 } from '../utils.js';
-import { slugify } from './../slugify.js';
+import { slugify } from '../slugify.js';
 
-export const headingCompiler = ({ renderer, router, compilerClass }) =>
+export const headingCompiler = ({ renderer, router, compiler }) =>
   (renderer.heading = function ({ tokens, depth }) {
     const text = this.parser.parseInline(tokens);
     let { str, config } = getAndRemoveConfig(text);
@@ -21,7 +21,7 @@ export const headingCompiler = ({ renderer, router, compilerClass }) =>
     const slug = slugify(config.id || str);
     const url = router.toURL(router.getCurrentPath(), { id: slug });
     nextToc.slug = url;
-    compilerClass.toc.push(nextToc);
+    compiler.toc.push(nextToc);
 
     // Note: tabindex="-1" allows programmatically focusing on heading
     // elements after navigation. This is preferred over focusing on the link
diff --git a/src/core/render/compiler/link.js b/src/core/render/compiler/link.js
index c7a3559eb..9483dd88b 100644
--- a/src/core/render/compiler/link.js
+++ b/src/core/render/compiler/link.js
@@ -6,7 +6,7 @@ export const linkCompiler = ({
   router,
   linkTarget,
   linkRel,
-  compilerClass,
+  compiler,
 }) =>
   (renderer.link = function ({ href, title = '', tokens }) {
     const attrs = [];
@@ -15,16 +15,16 @@ export const linkCompiler = ({
     linkTarget = config.target || linkTarget;
     linkRel =
       linkTarget === '_blank'
-        ? compilerClass.config.externalLinkRel || 'noopener'
+        ? compiler.config.externalLinkRel || 'noopener'
         : '';
     title = str;
 
     if (
       !isAbsolutePath(href) &&
-      !compilerClass._matchNotCompileLink(href) &&
+      !compiler._matchNotCompileLink(href) &&
       !config.ignore
     ) {
-      if (href === compilerClass.config.homepage) {
+      if (href === compiler.config.homepage) {
         href = 'README';
       }
 
diff --git a/src/core/render/index.js b/src/core/render/index.js
index e85a841c2..3ee35513b 100644
--- a/src/core/render/index.js
+++ b/src/core/render/index.js
@@ -82,7 +82,7 @@ export function Render(Base) {
         }
       }
 
-      dom.renderTo(markdownElm, html);
+      dom.setHTML(markdownElm, html);
 
       // Execute markdown <script>
       if (
@@ -287,7 +287,7 @@ export function Render(Base) {
         return null;
       }
 
-      dom.renderTo('.sidebar-nav', this.compiler.sidebar(text, maxLevel));
+      dom.setHTML('.sidebar-nav', this.compiler.sidebar(text, maxLevel));
 
       sidebarToggleEl.setAttribute('aria-expanded', !isMobile());
 
@@ -359,7 +359,7 @@ export function Render(Base) {
       const html = this.compiler.compile(text);
 
       ['.app-nav', '.app-nav-merged'].forEach(selector => {
-        dom.renderTo(selector, html);
+        dom.setHTML(selector, html);
         this.#addTextAsTitleAttribute(`${selector} a`);
       });
     }
@@ -500,7 +500,7 @@ export function Render(Base) {
         rootElm.style.setProperty('--cover-bg', mdCoverBg);
       }
 
-      dom.renderTo('.cover-main', html);
+      dom.setHTML('.cover-main', html);
 
       // Button styles
       dom
@@ -556,7 +556,7 @@ export function Render(Base) {
         html += tpl.main(config);
 
         // Render main app
-        dom.renderTo(el, html, true);
+        dom.setHTML(el, html, true);
       } else {
         this.rendered = true;
       }
diff --git a/src/core/util/dom.js b/src/core/util/dom.js
index 056a0d502..6d60eaf18 100644
--- a/src/core/util/dom.js
+++ b/src/core/util/dom.js
@@ -23,10 +23,10 @@ export function getNode(el, noCache = false) {
 /**
  *
  * @param {*} el the targt element or the selector
- * @param {*} content the content to be rendered
+ * @param {*} content the content to be rendered as HTML
  * @param {*} replace To replace the content (true) or insert instead (false) , default is false
  */
-export function renderTo(el, content, replace) {
+export function setHTML(el, content, replace) {
   const node = getNode(el);
   if (node) {
     node[replace ? 'outerHTML' : 'innerHTML'] = content;

From b9751e6d19809c4e07caeeef972a60c90beaca43 Mon Sep 17 00:00:00 2001
From: koy <koy@ko8e24.top>
Date: Wed, 14 Aug 2024 23:11:30 +0800
Subject: [PATCH 4/4] update: review

---
 src/core/render/compiler.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/core/render/compiler.js b/src/core/render/compiler.js
index cdce2ba32..b86166301 100644
--- a/src/core/render/compiler.js
+++ b/src/core/render/compiler.js
@@ -7,7 +7,7 @@ import { slugify } from './slugify.js';
 import { emojify } from './emojify.js';
 import { getAndRemoveConfig } from './utils.js';
 import { imageCompiler } from './compiler/image.js';
-import { headingCompiler } from './compiler/headling.js';
+import { headingCompiler } from './compiler/heading.js';
 import { highlightCodeCompiler } from './compiler/code.js';
 import { paragraphCompiler } from './compiler/paragraph.js';
 import { taskListCompiler } from './compiler/taskList.js';