Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FlatCollection to use the iiif-net package #7

Open
sarahos opened this issue Aug 30, 2024 · 0 comments
Open

Update FlatCollection to use the iiif-net package #7

sarahos opened this issue Aug 30, 2024 · 0 comments
Assignees

Comments

@sarahos
Copy link
Collaborator

sarahos commented Aug 30, 2024

This ticket will not contain changes for playwright testing and is more of a tech task

FlatCollection is used to show additional properties to a standard IIIF collection, it would make sense to use inheritance from the centralized iiif-net library collections. This was attempted earlier, but failed due to issues with serialization

see:
https://github.com/digirati-co-uk/iiif-net
https://github.com/dlcs/iiif-presentation/blob/feature/updateCollection/src/IIIFPresentation/Models/API/Collection/FlatCollection.cs

  • rename FlatCollection to PresentationCollection
  • investigate using inheritance between Collection and FlatCollection
  • Possible fix: allow custom serializers in the iiif-net library
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants