Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When an image and features is defined, additional build options are not allowed #473

Open
Roemer opened this issue Jun 19, 2024 · 1 comment

Comments

@Roemer
Copy link
Contributor

Roemer commented Jun 19, 2024

Hello all

I found out that defining an image and also features allows to build a new image with the desired features.
Unfortunately, it is not allowed to have image and build at the same time. I need build.options to pass additional parameters (add-host) to the docker command that is used to add the feature to the original image.

The only workaround right now is to create a Dockerfile with just the image as the FROM and then use build with the Dockerfile and not the image at all. Would be nice to be able to pass options when building an image with features as well instead of only when using a Dockerfile.

@samruddhikhandale
Copy link
Member

@Roemer Can we utilize runArgs? Something like 👇

{
  "image": "your-docker-image:latest",
  "runArgs": [
    "--add-host", "customhostname:192.168.1.100"
  ]
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@Roemer @samruddhikhandale and others