You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Some features edit .bashrc and .zshrc, such as [stuartleeks/shell-history](https://github.com/stuartleeks/dev-container-features/blob/main/src/shell-history/README.md) which needs to chown a folder that is mounted.
#374
Some features edit .bashrc and .zshrc, such as stuartleeks/shell-history which needs to chown a folder that is mounted.
The issue I'm experiencing comes when I use my custom dotfiles repo, which replaces any .zshrc files with a custom one, so any changes made from features are basically deleted.
Do you have any idea on how to fix this? I could source the old .zshrc in my custom file, but I'm not sure if that's a good idea. I was also thinking that there can be a "best practice" for devcontainer features to add stuff to .zshrc.devcontainers (and so on for bash and fish) so people can take this into account when making install scripts for devcontainer dotfiles.
Thanks for posting this @bgu5678, although I don't think this is an issue with the spec so this can be closed. The solution is probably to chown the folder during a lifecycle script (see: joshuanianji/devcontainer-features#40). I'll first have test it with my features and see how it goes though!
If it works well, I might send a PR to a couple other features with volume mounts.
Some features edit
.bashrc
and.zshrc
, such as stuartleeks/shell-history which needs tochown
a folder that is mounted.The issue I'm experiencing comes when I use my custom dotfiles repo, which replaces any
.zshrc
files with a custom one, so any changes made from features are basically deleted.Do you have any idea on how to fix this? I could source the old
.zshrc
in my custom file, but I'm not sure if that's a good idea. I was also thinking that there can be a "best practice" for devcontainer features to add stuff to.zshrc.devcontainers
(and so on for bash and fish) so people can take this into account when making install scripts for devcontainer dotfiles.Originally posted by @joshuanianji in #371
The text was updated successfully, but these errors were encountered: