Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot use vcpkg in manifest mode with cpp image #1133

Open
NoMore201 opened this issue Jul 23, 2024 · 2 comments
Open

Cannot use vcpkg in manifest mode with cpp image #1133

NoMore201 opened this issue Jul 23, 2024 · 2 comments

Comments

@NoMore201
Copy link

When using vcpkg in manifest mode, it is possible to specify a commit of the vcpkg repository to track via the builtin-baseline option, such as:

{
  "name": "test-vcpkg-template",
  "dependencies": [
    {
      "name": "expected-lite",
      "version>=": "0.6.3"
    }
  ],
  "builtin-baseline": "01acfdfde3ed99280d3883a8fccd5fa4408f5214"
}

Devcontainer cpp image clones vcpkg repository using the --depth=1 option (link to the code) preventing usage of vcpkg in manifest mode, unless manually modifying the container image to fetch all git history.

@samruddhikhandale
Copy link
Member

Hi 👋

Thanks for opening the issue. To keep the cpp image size minimal, we are intentionally using --depth=1. However, I understand how the builtin-baseline option might become unusable due to this.

Doing a full git clone would significantly increase the size of the cpp image. @NoMore201, do you think cloning up to the last N commits would be useful to you?

@NoMore201
Copy link
Author

Hello!

To be fair I'm not a vcpkg expert to tell if this is the right way to do things, since no one else complained so far. Anyway it is rather easy to modify the dev container to clone the entire history.

I would say to keep it like it is, unless someone else with more experience has something to add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants