Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devcontainer exec does not always propagate SIGTERM to docker exec #888

Open
akosyakov opened this issue Sep 5, 2024 · 1 comment
Open
Assignees
Labels
bug Something isn't working upstream Issue identified as 'upstream' component related (exists outside of Dev Containers CLI)

Comments

@akosyakov
Copy link

Steps to reproduce:

  • Run devcontainer exec without pty, for instance:
devcontainer exec --container-id 1234abcdefgh -- sleep infinity > /dev/null 2>&1
  • Check that on the host machine and inside the container you have infinity sleep process: ps -auxf |grep "infinity"
  • Interrupt devcontainer exec with SIGTERM, i.e. kill the process or just interrupt the terminal.
  • Check on the host machine the docker process is gone, but inside the container infinity sleep is dangling.

It seems docker exec is terminated without SIGTERM, leading to ungraceful termination.

@chrmarti
Copy link
Contributor

chrmarti commented Sep 5, 2024

This seems to be moby/moby#9098.

@chrmarti chrmarti self-assigned this Sep 5, 2024
@chrmarti chrmarti added bug Something isn't working upstream Issue identified as 'upstream' component related (exists outside of Dev Containers CLI) labels Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working upstream Issue identified as 'upstream' component related (exists outside of Dev Containers CLI)
Projects
None yet
Development

No branches or pull requests

2 participants