Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to publish feature to ghcr.io #793

Closed
tiwaojo opened this issue Apr 6, 2024 · 5 comments
Closed

Failed to publish feature to ghcr.io #793

tiwaojo opened this issue Apr 6, 2024 · 5 comments
Assignees

Comments

@tiwaojo
Copy link

tiwaojo commented Apr 6, 2024

Hello, I was presented with the following error message while trying to publish a minor update of my feature to ghcr.io repository through the devcontainer/action. My logs for my run can be found here. Moreover, the same behaviour was observed while running the following commands in the terminal.

devcontainer features publish -r ghcr.io -n tiwaojo/features ./src

I could confirm the output exists by navigating to the path. I also tried changing the feature version but received the same error message nonetheless.

Currently using @devcontainers/cli 0.58.0. Node.js v18.19.1. through a dev container on WSL.

@samruddhikhandale
Copy link
Member

Hi 👋

@tiwaojo By looking at https://github.com/tiwaojo/features/blob/main/src/mcap/devcontainer-feature.json#L3, it doesn't look correct. The Feature id should match with the folder name. Can you update and retest?

Learn more at https://containers.dev/implementors/features-distribution/#source-code

@joshspicer
Copy link
Member

I agree this mismatch here is likely the issue. The implementation will traverse the 'src' folder in this instance and is probably still using that identifier in place of the devcontainer-feature.json's id. We can likely harden that in the implementation to provide a better error

@tiwaojo
Copy link
Author

tiwaojo commented Apr 9, 2024

Hey @samruddhikhandale @joshspicer,

Thanks for catching my error. My release action now passes. And yes, a better error message will certainly be helpful.

@tiwaojo tiwaojo closed this as completed Apr 9, 2024
@joshspicer
Copy link
Member

Glad that helped! Agreed, i'll put up a PR to add a more helpful error. Reworking the commands to have a single source of truth is potentially more work than its worth, but i'll take a look there too.

@joshspicer
Copy link
Member

I've put up #797 to report this better in the future. Thanks for raising!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants