Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postStartCommand in devcontainer.json not being run #287

Closed
savvn001 opened this issue Apr 9, 2024 · 2 comments
Closed

postStartCommand in devcontainer.json not being run #287

savvn001 opened this issue Apr 9, 2024 · 2 comments
Assignees
Labels
info-needed Issue requires more information from poster

Comments

@savvn001
Copy link

savvn001 commented Apr 9, 2024

Does the postStartCommand in devcontainer.json get run at all? It doesn't seem to be run for me through github actions. Although it works fine when I start the devcontainer through VSCode extension.

Using the latest version:

      - name: Build and run dev container task
        uses: devcontainers/[email protected]
        with:
          noCache: true
          push: never
          runCmd: chmod +x ./ci_run_all_tests.sh && ./ci_run_all_tests.sh
@chrmarti
Copy link
Collaborator

I see the postStartCommand's output in the "start container" section of the action's log.

@chrmarti chrmarti self-assigned this Apr 10, 2024
@chrmarti chrmarti added the info-needed Issue requires more information from poster label Apr 10, 2024
@savvn001
Copy link
Author

@chrmarti Sorry again, this issue was related to the container not stopping/cleaning after a previous run. It was causing some odd things to happen where it looked like the postStartCommand was not being run again.

When it is run from a fresh build it works. I will close this issue since this feature is moved into my other issue:

#285

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

2 participants