Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad practice recommended with Hono + Pages #16446

Open
Cherry opened this issue Aug 25, 2024 · 0 comments
Open

Bad practice recommended with Hono + Pages #16446

Cherry opened this issue Aug 25, 2024 · 0 comments
Assignees
@jculvey @IgorMinar @kodster28 @dario-piotrowicz
Labels
content:edit Request for content edits documentation Documentation edits product:pages

Comments

@Cherry
Copy link
Contributor

Cherry commented Aug 25, 2024

Existing documentation URL(s)

https://developers.cloudflare.com/pages/framework-guides/deploy-a-hono-site/

What changes are you suggesting?

This page is encouraging users to use Hono to serve assets. This is bad practice. It'll cause an unnecessary Worker invocation (and therefore potentially additional fees for users), instead of using something like Pages Functions Routing, or _routes.json.

It's also extremely confusing to end-users why and how Pages is used here.

Additional information

No response
@Cherry Cherry added content:edit Request for content edits documentation Documentation edits labels Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jculvey jculvey

@IgorMinar IgorMinar

@kodster28 kodster28

@dario-piotrowicz dario-piotrowicz

Labels
content:edit Request for content edits documentation Documentation edits product:pages
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jculvey @IgorMinar @Cherry @kodster28 @dario-piotrowicz