Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAS S3 backend endpoint validation #1076

Open
hanygirgis opened this issue Jul 5, 2024 · 0 comments
Open

CAS S3 backend endpoint validation #1076

hanygirgis opened this issue Jul 5, 2024 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@hanygirgis
Copy link

Currently, adding a custom AWS-S3 CAS backend (with a custom endpoint) fails if the scheme is not part of the URL. For example:

$ chainloop cas-backend add aws-s3 --endpoint hostname:port ...

This fails with error "unexpected HTTP status code received from server: 504 (Gateway Timeout)"
However, it succeeds if a scheme is part of the endpoint (i.e. --endpoint https://hostname:port).
It might be a good idea to do validation of the endpoint and return a clearer message if it's invalid

@migmartri migmartri added good first issue Good for newcomers bug Something isn't working labels Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants