Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using lit-element or lit-html @event syntax, don't use sortAttributes in htmlMinifier #44

Open
moderndeveloperllc opened this issue Jan 13, 2020 · 3 comments

Comments

@moderndeveloperllc
Copy link

This is not an issue with your library, but you might want to put it in the hint for htmlMinifier. Using @event-style syntax in elements of your render() templates can cause issues if you use sortAttributes - kangax/html-minifier#1057. Basically the attributes get sorted, but the replacement strings don't.

@coreyfarrell
Copy link
Member

I would not object to a PR adding a note to the README along with the other notes about lit-html usage in the htmlMinifier section.

CC @LarsDenBakker not sure if this is something open-wc is aware of?

@LarsDenBakker
Copy link
Contributor

No I never encountered this before

@LarsDenBakker
Copy link
Contributor

Reading into this more thoroughly, this does seem like a plausible issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants