diff --git a/controllers/tests/kafkacluster_controller_envoy_test.go b/controllers/tests/kafkacluster_controller_envoy_test.go index 449959044..7a7d7ae78 100644 --- a/controllers/tests/kafkacluster_controller_envoy_test.go +++ b/controllers/tests/kafkacluster_controller_envoy_test.go @@ -70,13 +70,13 @@ func expectEnvoyLoadBalancer(ctx context.Context, kafkaCluster *v1beta1.KafkaClu Expect(loadBalancer.Spec.Ports[4].Name).To(Equal("tcp-health")) Expect(loadBalancer.Spec.Ports[4].Protocol).To(Equal(corev1.ProtocolTCP)) - Expect(loadBalancer.Spec.Ports[4].Port).To(BeEquivalentTo(v1beta1.DefaultEnvoyHealthCheckPort)) - Expect(loadBalancer.Spec.Ports[4].TargetPort.IntVal).To(BeEquivalentTo(v1beta1.DefaultEnvoyHealthCheckPort)) + Expect(loadBalancer.Spec.Ports[4].Port).To(BeEquivalentTo(kafkaCluster.Spec.EnvoyConfig.GetEnvoyHealthCheckPort())) + Expect(loadBalancer.Spec.Ports[4].TargetPort.IntVal).To(BeEquivalentTo(kafkaCluster.Spec.EnvoyConfig.GetEnvoyHealthCheckPort())) Expect(loadBalancer.Spec.Ports[5].Name).To(Equal("tcp-admin")) Expect(loadBalancer.Spec.Ports[5].Protocol).To(Equal(corev1.ProtocolTCP)) - Expect(loadBalancer.Spec.Ports[5].Port).To(BeEquivalentTo(v1beta1.DefaultEnvoyAdminPort)) - Expect(loadBalancer.Spec.Ports[5].TargetPort.IntVal).To(BeEquivalentTo(v1beta1.DefaultEnvoyAdminPort)) + Expect(loadBalancer.Spec.Ports[5].Port).To(BeEquivalentTo(kafkaCluster.Spec.EnvoyConfig.GetEnvoyAdminPort())) + Expect(loadBalancer.Spec.Ports[5].TargetPort.IntVal).To(BeEquivalentTo(kafkaCluster.Spec.EnvoyConfig.GetEnvoyAdminPort())) } func expectEnvoyConfigMap(ctx context.Context, kafkaCluster *v1beta1.KafkaCluster, eListenerTemplate string) { @@ -395,13 +395,13 @@ func expectEnvoyWithConfigAz1(ctx context.Context, kafkaCluster *v1beta1.KafkaCl Expect(loadBalancer.Spec.Ports[2].Name).To(Equal("tcp-health")) Expect(loadBalancer.Spec.Ports[2].Protocol).To(Equal(corev1.ProtocolTCP)) - Expect(loadBalancer.Spec.Ports[2].Port).To(BeEquivalentTo(v1beta1.DefaultEnvoyHealthCheckPort)) - Expect(loadBalancer.Spec.Ports[2].TargetPort.IntVal).To(BeEquivalentTo(v1beta1.DefaultEnvoyHealthCheckPort)) + Expect(loadBalancer.Spec.Ports[2].Port).To(BeEquivalentTo(kafkaCluster.Spec.EnvoyConfig.GetEnvoyHealthCheckPort())) + Expect(loadBalancer.Spec.Ports[2].TargetPort.IntVal).To(BeEquivalentTo(kafkaCluster.Spec.EnvoyConfig.GetEnvoyHealthCheckPort())) Expect(loadBalancer.Spec.Ports[3].Name).To(Equal("tcp-admin")) Expect(loadBalancer.Spec.Ports[3].Protocol).To(Equal(corev1.ProtocolTCP)) - Expect(loadBalancer.Spec.Ports[3].Port).To(BeEquivalentTo(v1beta1.DefaultEnvoyAdminPort)) - Expect(loadBalancer.Spec.Ports[3].TargetPort.IntVal).To(BeEquivalentTo(v1beta1.DefaultEnvoyAdminPort)) + Expect(loadBalancer.Spec.Ports[3].Port).To(BeEquivalentTo(kafkaCluster.Spec.EnvoyConfig.GetEnvoyAdminPort())) + Expect(loadBalancer.Spec.Ports[3].TargetPort.IntVal).To(BeEquivalentTo(kafkaCluster.Spec.EnvoyConfig.GetEnvoyAdminPort())) var deployment appsv1.Deployment deploymentName := fmt.Sprintf("envoy-test-az1-%s", kafkaCluster.Name) @@ -425,12 +425,12 @@ func expectEnvoyWithConfigAz1(ctx context.Context, kafkaCluster *v1beta1.KafkaCl }, corev1.ContainerPort{ Name: "tcp-admin", - ContainerPort: v1beta1.DefaultEnvoyAdminPort, + ContainerPort: kafkaCluster.Spec.EnvoyConfig.GetEnvoyAdminPort(), Protocol: corev1.ProtocolTCP, }, corev1.ContainerPort{ Name: "tcp-health", - ContainerPort: v1beta1.DefaultEnvoyHealthCheckPort, + ContainerPort: kafkaCluster.Spec.EnvoyConfig.GetEnvoyHealthCheckPort(), Protocol: corev1.ProtocolTCP, }, )) @@ -605,13 +605,13 @@ func expectEnvoyWithConfigAz2(ctx context.Context, kafkaCluster *v1beta1.KafkaCl Expect(loadBalancer.Spec.Ports[3].Name).To(Equal("tcp-health")) Expect(loadBalancer.Spec.Ports[3].Protocol).To(Equal(corev1.ProtocolTCP)) - Expect(loadBalancer.Spec.Ports[3].Port).To(BeEquivalentTo(v1beta1.DefaultEnvoyHealthCheckPort)) - Expect(loadBalancer.Spec.Ports[3].TargetPort.IntVal).To(BeEquivalentTo(v1beta1.DefaultEnvoyHealthCheckPort)) + Expect(loadBalancer.Spec.Ports[3].Port).To(BeEquivalentTo(kafkaCluster.Spec.EnvoyConfig.GetEnvoyHealthCheckPort())) + Expect(loadBalancer.Spec.Ports[3].TargetPort.IntVal).To(BeEquivalentTo(kafkaCluster.Spec.EnvoyConfig.GetEnvoyHealthCheckPort())) Expect(loadBalancer.Spec.Ports[4].Name).To(Equal("tcp-admin")) Expect(loadBalancer.Spec.Ports[4].Protocol).To(Equal(corev1.ProtocolTCP)) - Expect(loadBalancer.Spec.Ports[4].Port).To(BeEquivalentTo(v1beta1.DefaultEnvoyAdminPort)) - Expect(loadBalancer.Spec.Ports[4].TargetPort.IntVal).To(BeEquivalentTo(v1beta1.DefaultEnvoyAdminPort)) + Expect(loadBalancer.Spec.Ports[4].Port).To(BeEquivalentTo(kafkaCluster.Spec.EnvoyConfig.GetEnvoyAdminPort())) + Expect(loadBalancer.Spec.Ports[4].TargetPort.IntVal).To(BeEquivalentTo(kafkaCluster.Spec.EnvoyConfig.GetEnvoyAdminPort())) var deployment appsv1.Deployment deploymentName := fmt.Sprintf("envoy-test-az2-%s", kafkaCluster.Name) @@ -640,12 +640,12 @@ func expectEnvoyWithConfigAz2(ctx context.Context, kafkaCluster *v1beta1.KafkaCl }, corev1.ContainerPort{ Name: "tcp-admin", - ContainerPort: v1beta1.DefaultEnvoyAdminPort, + ContainerPort: kafkaCluster.Spec.EnvoyConfig.GetEnvoyAdminPort(), Protocol: corev1.ProtocolTCP, }, corev1.ContainerPort{ Name: "tcp-health", - ContainerPort: v1beta1.DefaultEnvoyHealthCheckPort, + ContainerPort: kafkaCluster.Spec.EnvoyConfig.GetEnvoyHealthCheckPort(), Protocol: corev1.ProtocolTCP, }, )) diff --git a/go.mod b/go.mod index 9d4d6275f..106c421c3 100644 --- a/go.mod +++ b/go.mod @@ -10,7 +10,7 @@ require ( github.com/banzaicloud/istio-client-go v0.0.17 github.com/banzaicloud/istio-operator/api/v2 v2.15.1 github.com/banzaicloud/k8s-objectmatcher v1.8.0 - github.com/banzaicloud/koperator/api v0.28.7 + github.com/banzaicloud/koperator/api v0.28.8 github.com/banzaicloud/koperator/properties v0.4.1 github.com/cert-manager/cert-manager v1.11.2 github.com/cisco-open/cluster-registry-controller/api v0.2.5 diff --git a/go.sum b/go.sum index 4286049cb..ee7951bc7 100644 --- a/go.sum +++ b/go.sum @@ -64,8 +64,8 @@ github.com/banzaicloud/istio-operator/api/v2 v2.15.1 h1:BZg8COvoOJtfx/dgN7KpoOnc github.com/banzaicloud/istio-operator/api/v2 v2.15.1/go.mod h1:5qCpwWlIfxiLvBfTvT2mD2wp5RlFCDEt8Xql4sYPNBc= github.com/banzaicloud/k8s-objectmatcher v1.8.0 h1:Nugn25elKtPMTA2br+JgHNeSQ04sc05MDPmpJnd1N2A= github.com/banzaicloud/k8s-objectmatcher v1.8.0/go.mod h1:p2LSNAjlECf07fbhDyebTkPUIYnU05G+WfGgkTmgeMg= -github.com/banzaicloud/koperator/api v0.28.7 h1:G6ICLzuz6Tumcsl9ZaqZ46ccwdAc1rXjidP03v6Kqp4= -github.com/banzaicloud/koperator/api v0.28.7/go.mod h1:AGGQ+aTBklaaG8ErotNPlP/nS47MYLc/jFVW7AsDiEE= +github.com/banzaicloud/koperator/api v0.28.8 h1:7J6B+s9D5WhTNKC5oQwk4USN4h2gUP4GLfNmfq2yb1c= +github.com/banzaicloud/koperator/api v0.28.8/go.mod h1:AGGQ+aTBklaaG8ErotNPlP/nS47MYLc/jFVW7AsDiEE= github.com/banzaicloud/koperator/properties v0.4.1 h1:SB2QgXlcK1Dc7Z1rg65PJifErDa8OQnoWCCJgmC7SGc= github.com/banzaicloud/koperator/properties v0.4.1/go.mod h1:TcL+llxuhW3UeQtVEDYEXGouFLF2P+LuZZVudSb6jyA= github.com/banzaicloud/operator-tools v0.28.0 h1:GSfc0qZr6zo7WrNxdgWZE1LcTChPU8QFYOTDirYVtIM= diff --git a/pkg/resources/kafka/pod.go b/pkg/resources/kafka/pod.go index 227cfdbc6..c2e627250 100644 --- a/pkg/resources/kafka/pod.go +++ b/pkg/resources/kafka/pod.go @@ -533,7 +533,7 @@ func generateEnvConfig(brokerConfig *v1beta1.BrokerConfig, defaultEnvVars []core if _, ok := envs["KAFKA_JVM_PERFORMANCE_OPTS"]; !ok || brokerConfig.KafkaJVMPerfOpts != "" { envs["KAFKA_JVM_PERFORMANCE_OPTS"] = corev1.EnvVar{ Name: "KAFKA_JVM_PERFORMANCE_OPTS", - Value: brokerConfig.GetKafkaPerfJmvOpts(), + Value: brokerConfig.GetKafkaPerfJvmOpts(), } } // Sort map values by key to avoid diff in sequence diff --git a/tests/e2e/go.mod b/tests/e2e/go.mod index 563cf7a10..29b3191f0 100644 --- a/tests/e2e/go.mod +++ b/tests/e2e/go.mod @@ -6,7 +6,7 @@ require ( emperror.dev/errors v0.8.1 github.com/Masterminds/sprig v2.22.0+incompatible github.com/banzaicloud/koperator v0.25.1 - github.com/banzaicloud/koperator/api v0.28.7 + github.com/banzaicloud/koperator/api v0.28.8 github.com/cisco-open/k8s-objectmatcher v1.9.0 github.com/gruntwork-io/terratest v0.41.26 github.com/onsi/ginkgo/v2 v2.9.5 diff --git a/tests/e2e/go.sum b/tests/e2e/go.sum index 6e8a0bf6a..c69c724d9 100644 --- a/tests/e2e/go.sum +++ b/tests/e2e/go.sum @@ -59,8 +59,8 @@ github.com/banzaicloud/istio-client-go v0.0.17 h1:wiplbM7FDiIHopujInAnin3zuovtVc github.com/banzaicloud/istio-client-go v0.0.17/go.mod h1:rpnEYYGHzisx8nARl2d30Oq38EeCX0/PPaxMaREfE9I= github.com/banzaicloud/koperator v0.25.1 h1:baWLnsMOitml8bJ/6zAH1XGYdqM0mu9YzQY6zioKxlk= github.com/banzaicloud/koperator v0.25.1/go.mod h1:QLU5npzAcVE1cCxtPrnpWsw3Pm59TVikXFu65ZDNImw= -github.com/banzaicloud/koperator/api v0.28.7 h1:G6ICLzuz6Tumcsl9ZaqZ46ccwdAc1rXjidP03v6Kqp4= -github.com/banzaicloud/koperator/api v0.28.7/go.mod h1:AGGQ+aTBklaaG8ErotNPlP/nS47MYLc/jFVW7AsDiEE= +github.com/banzaicloud/koperator/api v0.28.8 h1:7J6B+s9D5WhTNKC5oQwk4USN4h2gUP4GLfNmfq2yb1c= +github.com/banzaicloud/koperator/api v0.28.8/go.mod h1:AGGQ+aTBklaaG8ErotNPlP/nS47MYLc/jFVW7AsDiEE= github.com/banzaicloud/koperator/properties v0.4.1 h1:SB2QgXlcK1Dc7Z1rg65PJifErDa8OQnoWCCJgmC7SGc= github.com/banzaicloud/koperator/properties v0.4.1/go.mod h1:TcL+llxuhW3UeQtVEDYEXGouFLF2P+LuZZVudSb6jyA= github.com/banzaicloud/operator-tools v0.28.0 h1:GSfc0qZr6zo7WrNxdgWZE1LcTChPU8QFYOTDirYVtIM=