Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: timezone issue while running mage tests #3791

Open
briheet opened this issue Jul 15, 2024 · 0 comments
Open

Test: timezone issue while running mage tests #3791

briheet opened this issue Jul 15, 2024 · 0 comments

Comments

@briheet
Copy link

briheet commented Jul 15, 2024

Describe the bug
While checking out the issue with improving repo test coverage, i ran mage tests which gave the following results
2024-07-15-12:37:50-screenshot

groupjobs_test.go:1113: Error Trace: /home/briheet/Open/armada/internal/lookoutv2/repository/groupjobs_test.go:1113 /home/briheet/Open/armada/internal/lookoutv2/repository/groupjobs_test.go:28 /home/briheet/Open/armada/internal/common/database/db_testutil.go:59 /home/briheet/Open/armada/internal/common/database/lookout/util.go:15 /home/briheet/Open/armada/internal/lookoutv2/repository/groupjobs_test.go:24 /home/briheet/Open/armada/internal/lookoutv2/repository/groupjobs_test.go:1011 Error: Not equal: expected: []*model.JobGroup{(*model.JobGroup)(0xc00025fc00), (*model.JobGroup)(0xc00025fd40), (*model.JobGroup)(0xc00025fe00), (*model.JobGroup)(0xc00025ff40)} actual : []*model.JobGroup{(*model.JobGroup)(0xc000692020), (*model.JobGroup)(0xc000692040), (*model.JobGroup)(0xc000692140), (*model.JobGroup)(0xc0006921c0)}

    	           	Diff:
    	           	--- Expected
    	           	+++ Actual
    	           	@@ -3,3 +3,3 @@
    	           	  Aggregates: (map[string]interface {}) (len=2) {
    	           	-   (string) (len=18) "lastTransitionTime": (string) (len=25) "2022-03-01T21:24:05+05:30",
    	           	+   (string) (len=18) "lastTransitionTime": (string) (len=20) "2022-03-01T15:54:05Z",
    	           	   (string) (len=9) "submitted": (string) (len=20) "2022-03-01T15:24:05Z"
    	           	@@ -11,3 +11,3 @@
    	           	  Aggregates: (map[string]interface {}) (len=2) {
    	           	-   (string) (len=18) "lastTransitionTime": (string) (len=25) "2022-03-01T20:44:05+05:30",
    	           	+   (string) (len=18) "lastTransitionTime": (string) (len=20) "2022-03-01T15:14:05Z",
    	           	   (string) (len=9) "submitted": (string) (len=20) "2022-03-01T15:05:05Z"
    	           	@@ -19,3 +19,3 @@
    	           	  Aggregates: (map[string]interface {}) (len=2) {
    	           	-   (string) (len=18) "lastTransitionTime": (string) (len=25) "2022-03-01T20:39:05+05:30",
    	           	+   (string) (len=18) "lastTransitionTime": (string) (len=20) "2022-03-01T15:09:05Z",
    	           	   (string) (len=9) "submitted": (string) (len=20) "2022-03-01T15:07:05Z"
    	           	@@ -27,3 +27,3 @@
    	           	  Aggregates: (map[string]interface {}) (len=2) {
    	           	-   (string) (len=18) "lastTransitionTime": (string) (len=25) "2022-03-01T20:34:05+05:30",
    	           	+   (string) (len=18) "lastTransitionTime": (string) (len=20) "2022-03-01T15:04:05Z",
    	           	   (string) (len=9) "submitted": (string) (len=20) "2022-03-01T15:04:05Z"
    	Test:       	TestGroupByAnnotationWithFiltersAndAggregates

DONE 2034 tests, 3 failures in 151.295s
Error: exit status 1

Files Or Markdown that can reproduce the issue
mage tests

Expected behavior
It should clear all the tests.

Imporvement
Adding a function which converts to UTC and formats would help us. If this is ok, i could push a small pr :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant