Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] [Issue 485]Fixed panic caused by memory not aligned in arm32 arch #1286

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

dream-kzx
Copy link
Contributor

@dream-kzx dream-kzx commented Sep 17, 2024

Motivation

Fixed panic caused by memory not aligned in arm32 arch.

Modifications

Move variable that uses 64-bit atomic operations to the front of the structure so that it is 64-bit aligned.

Verifying this change

  • Make sure that the change passes the CI checks.
    This change is a trivial rework / code cleanup without any test coverage.

Documentation

  • Does this pull request introduce a new feature? (no)

Copy link
Member

@shoothzj shoothzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this this useful for arm32 users

@shoothzj
Copy link
Member

I think this will fix #485

Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contributing @dream-kzx

@shoothzj shoothzj merged commit 188dba9 into apache:master Sep 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants