Fixed Unable to create a domain when networkdomain is mentioned and cleared #9637
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9637 +/- ##
===========================================
Coverage 15.57% 15.57%
Complexity 12052 12052
===========================================
Files 5505 5505
Lines 482738 482741 +3
Branches 58961 60951 +1990
===========================================
+ Hits 75203 75204 +1
- Misses 399226 399229 +3
+ Partials 8309 8308 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
loks good @FelipeM525 , can you base of the 4.19 branch? |
… with the field networkdomain as an empty string whenever the user typed something in the form and cleared it causing an exception
FelipeM525
force-pushed
the
fix-create-domain-form
branch
from
45bfd41
to
b7366ac
Compare
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
DaanHoogland
approved these changes
Sep 5, 2024
|
@kiranchavala a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
kiranchavala
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes !9623
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
I tested this PR by typing inside the networkdomain field in the Add domain form and then clearing it, which ended up working as expected after the proposed changes.