Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change (breaking!): Rename import to airbyte_api to make airbyte-api compatible with PyAirbyte #66

Merged
merged 4 commits into from
Apr 8, 2024

Conversation

aaronsteers
Copy link
Contributor

@aaronsteers aaronsteers commented Mar 25, 2024

Resolves #67

@aaronsteers aaronsteers marked this pull request as draft March 25, 2024 21:49
@aaronsteers
Copy link
Contributor Author

I don't know how to run codegen, so I've created a new branch with manual rename/move.

aj/manual_rename_dir

@simplesagar
Copy link
Contributor

If you merge this and then go to Actions tab --> Pick the workflow "Generate" --> Run Workflow (click the 'force generate' option since the spec has not changed

@aaronsteers aaronsteers marked this pull request as ready for review April 1, 2024 18:30
@aaronsteers aaronsteers changed the title [Draft] make airbyte-api compatible with PyAirbyte Change (breaking!): Rename import to airbyte_api to make airbyte-api compatible with PyAirbyte Apr 1, 2024
@aaronsteers
Copy link
Contributor Author

aaronsteers commented Apr 1, 2024

Thanks, @simplesagar ! Who else do you think we should add as approver here?

Cc @bgroff , @bindipankhudi

@aaronsteers
Copy link
Contributor Author

@airbytehq/platform-enablement - This will be a breaking change. Flagging for visibility + feedback.

@aaronsteers aaronsteers merged commit a439ef8 into main Apr 8, 2024
@aaronsteers aaronsteers deleted the aj/make-compatible-with-pyairbyte branch April 8, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve compatibility conflicts with PyAirbyte (rename library and rebuild)
2 participants