Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review testConvexRewriterOnMessageBoundsBasicInnerUnconditional and testConvexRewriterOnMessageBoundsBasicInnerConditional #32

Open
GoogleCodeExporter opened this issue May 9, 2015 · 0 comments

Comments

@GoogleCodeExporter
Copy link

The clean up of syntax trees and expressions has made apparently a problem with 
comparing expected and actual Rational numbers in unit tests.

These tests involve, among others, a Rational-valued symbol with value 6/7, 
which is output as 0.857142857. However, writing 6/7 as a decimal results in a 
periodic decimal expansion, so this Rational does not equal an expected value 
written down as 0.857142857. In fact, it will not equal *any* finite decimal 
description.

I am not quite sure how this used to work, but I left the old methods around 
for reproduction. It seems that it should not have worked though, and if it 
did, it was by some other covering problem.

It seems that one way of solving the problem is to introduce notation for 
specifying Rational-valued symbols by using fractions. Simply writing a 
fraction is not enough because it will be taken as a function application of / 
and still not compare as equal to a Rational symbol. This is aic-expresso issue 
#44.

Meanwhile, for these tests to work, one can modify it so that the result is not 
a periodic decimal expansion. I was going to do that when I saw comments inside 
the test predicting that indeed it would not do so. So a problem going on seems 
to be why this is not happening, and that is what this issue is about.

Original issue reported on code.google.com by [email protected] on 23 Apr 2014 at 1:39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant